Skip to content

Code quality: Simplify handling of dropped files #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 11, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jan 7, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Removes (looks like) unnecessary RemoteDataObject.cs & CheckDragNeedsFulltrust() method.
To be considered after PR #10925 is merged.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 marked this pull request as ready for review January 8, 2023 08:14
Copy link
Contributor

@jiejasonliu jiejasonliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@gave92 gave92 added the ready to merge Pull requests that are approved and ready to merge label Jan 10, 2023
@yaira2
Copy link
Member

yaira2 commented Jan 10, 2023

@gave92 should this be merge?

@gave92
Copy link
Member Author

gave92 commented Jan 10, 2023

Yeah if approvals from @jiejasonliu and luke are valid :)
Edit: if possible lets not skip insider testing for this kind of changes!
If you're about to publish directly to stable this can totally wait.

@yaira2 yaira2 merged commit 34ab09c into files-community:main Jan 11, 2023
@gave92 gave92 deleted the simplify_drop branch January 11, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants