Skip to content

Fix: Fixed issue with dragging files to extract from archive #10925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jiejasonliu
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes

  • More than likely a WinRT API issue with GetStorageItemsAsync() only yielding up 16 items
    • Did some digging around, reproduced this on other UWP and WinAppSDK apps
    • Also reproduced on Windows Terminal (microsoft/terminal), they use the same API for dragging and dropping paths
  • Workaround by using reading the DROPFILES struct for file paths in the data package

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)

Files-8485.mp4

@yaira2 yaira2 changed the title Fix: Include all items when receiving drag-and-drop event Fix: Fixed issue with dragging files to extract from archive Jan 5, 2023
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 7, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit c810e41 into files-community:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can only extract 16 files with drag to unzip
3 participants