Skip to content

Fix: Fixed issue where properties window was always on top #10897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 1, 2023
Merged

Fix: Fixed issue where properties window was always on top #10897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37b279e
Fix: Fixed issue where properties window was always on top
yaira2 Jan 1, 2023
eda14fa
Increased default width
yaira2 Jan 1, 2023
fbc2496
Fixed spacing in security window
yaira2 Jan 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Files.App/Helpers/FilePropertiesHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,12 @@ public static async Task OpenPropertiesWindowAsync(object item, IShellPage assoc

var propertiesWindow = new WinUIEx.WindowEx
{
IsAlwaysOnTop = true,
IsMinimizable = false,
IsMaximizable = false,
MinWidth = 460,
MinHeight = 550,
Width = 550,
Height = 550,
Content = frame,
Backdrop = new WinUIEx.MicaSystemBackdrop(),
};
Expand All @@ -81,7 +82,6 @@ public static async Task OpenPropertiesWindowAsync(object item, IShellPage assoc
appWindow.TitleBar.ButtonBackgroundColor = Colors.Transparent;
appWindow.TitleBar.ButtonInactiveBackgroundColor = Colors.Transparent;

appWindow.Resize(new SizeInt32(460, 550));
appWindow.SetIcon(LogoPath);

if (frame.Content is Properties properties)
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/Views/Pages/PropertiesSecurityAdvanced.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
Text="{x:Bind DialogTitle}" />

<ScrollViewer Grid.Row="1">
<StackPanel Padding="12,0,12,12" Spacing="8">
<StackPanel Padding="12,0,12,12" Spacing="4">
<Grid
Padding="8"
Background="{ThemeResource CardBackgroundFillColorDefaultBrush}"
Expand Down