Skip to content

Fix: Fixed issue where properties window was always on top #10897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 1, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 1, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixed issue where properties window was always on top

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 merged commit 1a21156 into main Jan 1, 2023
@yaira2 yaira2 deleted the ya/FixAlwaysOnTop branch January 1, 2023 18:58
@gave92
Copy link
Member

gave92 commented Jan 1, 2023

Didn't we have a problem where Properties would open behind Files? Does it not come back doing this?

@yaira2
Copy link
Member Author

yaira2 commented Jan 1, 2023

The issue is back (can't reproduce it consistently) but it introduced a bigger problem where the window was on top of everything else. This was most noticeable when trying to open the advanced permissions window.

@gave92
Copy link
Member

gave92 commented Jan 1, 2023

I think the idea was to put the window always on top only for a short time as a workaround, but we removed/ forgot the code to make it stop being on top after open.
Perhaps reopen tbe old issue regarding opening behind if any?

@yaira2
Copy link
Member Author

yaira2 commented Jan 1, 2023

#9926

@ferrariofilippo
Copy link
Contributor

Just checked the commit history and it seems that the line you removed (IsAlwaysOnTop = true) was added in #10294
I think we could solve this problem implementing @gave92 solution proposed in #9973

@gave92
Copy link
Member

gave92 commented Jan 2, 2023

Oh you're right, I assumed that setting "alwaysontop" was the fix for #9926 but it wasn't. The fix from #9973 is still in place and appears to be working. I can't repro #9926 even after removing "alwaysontop".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants