Skip to content

Feature: Show drive name on tab header #10889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2023
Merged

Feature: Show drive name on tab header #10889

merged 3 commits into from
Jan 4, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
1

hecksmosis
hecksmosis approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuaintMako
QuaintMako approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me.

yaira2
yaira2 reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 4, 2023
@yaira2 yaira2 merged commit 1c03ca4 into files-community:main Jan 4, 2023
@ferrariofilippo ferrariofilippo deleted the Feature_Drive_Name_On_Tab branch January 4, 2023 19:47
@benny779
Copy link

benny779 commented Jan 5, 2023

Thanks friends.
That was fast...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

@hecksmosis hecksmosis hecksmosis approved these changes

@QuaintMako QuaintMako QuaintMako approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Show drive name on tab header
5 participants
@ferrariofilippo @benny779 @yaira2 @hecksmosis @QuaintMako