Fix: Fixed issue where changing file permission for multiple files simultaneously would crash the app

[hecksmosis]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Bug: Changing file permission for multiple files simultaneously crashes app #10870

Validation
How did you test these changes?

• Built and ran the app

[QuaintMako]

While this does fix the crash for me, I'm not sure if the fix is the correct solution.

It reminds me of #10728 where I fixed a crash with a surface fix, but Gave92 did some exploration and fixed an bigger underlying problem.

Here we have a null object, while the Properties.xaml.cs can hold the several objects in the page inside its navParameterItem field it seems. Mave the SaveChangesAsync should take a list of ListedItem instead of one? I am not sure, it's only a surface level analysis here.

I'd suggest to take this fix, for it fixes a pretty important problem : if the application crashes, you simply lose your files. And it's not gonna be in the recycle bin from what I can see. But we need to dive further into the problem and fix the root of the cause.

[gave92]

Indeed fairly sure this would break renaming Drives.

Edit: pushed a suggested change. ItemFileName being null is not related to the item parameter being null (e.g for Drives). The parameter was confusing, I've removed it and now SaveBaseAsync() has similar signature of the other Save methods. Just in case I've also added a null check on ItemFileName itself.

[QuaintMako]

LGTM.

[hecksmosis]

Is it ok now?

[QuaintMako]

LGTM.