Skip to content

Fix: Fixed crash that would occur when switching between Network and Recycle Bin #10728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 18, 2022
Merged

Fix: Fixed crash that would occur when switching between Network and Recycle Bin #10728

merged 7 commits into from
Dec 18, 2022

Conversation

QuaintMako
Copy link
Contributor

@QuaintMako QuaintMako commented Dec 15, 2022 •
edited by yaira2
Loading

Resolved / Related Issues

What has been done

  • Wrapped the acquisition of the ShellItem inside a try...catch... so the exception raised when a path not valid would be given is no longer making the application crash.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@gave92 gave92 self-requested a review December 16, 2022 00:25
yaira2
yaira2 previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 16, 2022
@yaira2 yaira2 changed the title Fix: Fixed crash when going from Network to Recycle Bin via Sidebar Fix: Fixed crash that would occur when switching between Network and Recycle Bin Dec 16, 2022
@gave92
Copy link
Member

gave92 commented Dec 16, 2022

If it can wait I'd like to take a look at this.

@QuaintMako
Copy link
Contributor Author

@gave92 solution is much cleaner. The issue I offer felt like a makeshift fix, thanks for having looking into it !

QuaintMako
QuaintMako commented Dec 17, 2022
View reviewed changes
Copy link
Contributor Author

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gave92
Copy link
Member

gave92 commented Dec 17, 2022 •
edited
Loading

Thanks, it's still missing something. Do you confirm it solves the linked issue? Edit: I think I've corrected the underlying issue, but I've left the added try-catch in GetFile() as I found it's needed in some cases.

@gave92 gave92 force-pushed the 10715_CrashNetworkToRecycleBin branch from 5f60056 to 355544b Compare December 18, 2022 02:24
@yaira2
Copy link
Member

yaira2 commented Dec 18, 2022

as I found it's needed in some cases.

Do you know where it's still needed? Might be useful to add a comment.

@gave92
Copy link
Member

gave92 commented Dec 18, 2022

Do you know where it's still needed? Might be useful to add a comment.

Done!

yaira2
yaira2 approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 97df461 into files-community:main Dec 18, 2022
@QuaintMako QuaintMako mentioned this pull request Dec 30, 2022
Merged
1 task
@QuaintMako QuaintMako deleted the 10715_CrashNetworkToRecycleBin branch January 2, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@gave92 gave92 Awaiting requested review from gave92

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App may crash when clicking on Network or Recycle Bin in Sidebar
3 participants
@QuaintMako @gave92 @yaira2