Skip to content

Remove OpenProtectedFileForRead function #10285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2022
Merged

Remove OpenProtectedFileForRead function #10285

merged 2 commits into from
Oct 23, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 23, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Removes unnecessary OpenProtectedFileForRead function. The function was used when opening files from inside an archive due to UWP limitations but it's not necessary anymore.

Validation
How did you test these changes?

  • Built and ran the app
  • Launch a file from inside an archive and check it still works

yaira2
yaira2 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 23, 2022
@yaira2 yaira2 merged commit 1359aa4 into files-community:main Oct 23, 2022
@gave92 gave92 deleted the rem_openprotected branch October 24, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2