Remove OpenProtectedFileForRead function (#10285)

Author: gave92

src/Files.App/Filesystem/StorageItems/ZipStorageFile.cs

@@ -462,16 +462,16 @@ private async Task<BaseBasicProperties> GetBasicProperties()
                 : new ZipFileBasicProperties(entry);
         }
 
-        private IAsyncOperation<SevenZipExtractor> OpenZipFileAsync(bool openProtected = false)
+        private IAsyncOperation<SevenZipExtractor> OpenZipFileAsync()
         {
             return AsyncInfo.Run<SevenZipExtractor>(async (cancellationToken) =>
             {
-                var zipFile = await OpenZipFileAsync(FileAccessMode.Read, openProtected);
+                var zipFile = await OpenZipFileAsync(FileAccessMode.Read);
                 return zipFile is not null ? new SevenZipExtractor(zipFile) : null;
             });
         }
 
-        private IAsyncOperation<Stream> OpenZipFileAsync(FileAccessMode accessMode, bool openProtected = false)
+        private IAsyncOperation<Stream> OpenZipFileAsync(FileAccessMode accessMode)
         {
             return AsyncInfo.Run<Stream>(async (cancellationToken) =>
             {
@@ -482,9 +482,7 @@ private IAsyncOperation<Stream> OpenZipFileAsync(FileAccessMode accessMode, bool
                 }
                 else
                 {
-                    var hFile = openProtected ?
-                        NativeFileOperationsHelper.OpenProtectedFileForRead(containerPath) :
-                        NativeFileOperationsHelper.OpenFileForRead(containerPath, readWrite);
+                    var hFile = NativeFileOperationsHelper.OpenFileForRead(containerPath, readWrite);
                     if (hFile.IsInvalid)
                     {
                         return null;
@@ -500,9 +498,7 @@ private StreamedFileDataRequestedHandler ZipDataStreamingHandler(string name)
             {
                 try
                 {
-                    // If called from here it fails with Access Denied?!
-                    //var hFile = NativeFileOperationsHelper.OpenFileForRead(ContainerPath);
-                    using SevenZipExtractor zipFile = await OpenZipFileAsync(openProtected: true);
+                    using SevenZipExtractor zipFile = await OpenZipFileAsync();
                     if (zipFile == null || zipFile.ArchiveFileData == null)
                     {
                         request.FailAndClose(StreamedFileFailureMode.CurrentlyUnavailable);

src/Files.App/Helpers/FileOperationsHelpers.cs

@@ -31,21 +31,6 @@ public class FileOperationsHelpers
     {
         private static readonly ProgressHandler progressHandler = new();
 
-        public static long? GetFileHandle(string filePath, bool readWrite, int processId)
-        {
-            using var hFile = Kernel32.CreateFile(filePath, Kernel32.FileAccess.GENERIC_READ | (readWrite ? Kernel32.FileAccess.GENERIC_WRITE : 0), FileShare.ReadWrite, null, FileMode.Open, FileFlagsAndAttributes.FILE_ATTRIBUTE_NORMAL);
-            
-            if (hFile.IsInvalid)
-                return null;
-
-            using var uwpProces = System.Diagnostics.Process.GetProcessById(processId);
-
-            if (!Kernel32.DuplicateHandle(Kernel32.GetCurrentProcess(), hFile.DangerousGetHandle(), uwpProces.Handle, out var targetHandle, 0, false, Kernel32.DUPLICATE_HANDLE_OPTIONS.DUPLICATE_SAME_ACCESS))
-                return null;
-
-            return targetHandle.ToInt64();
-        }
-
         public static Task SetClipboard(string[] filesToCopy, DataPackageOperation operation)
         {
             return Win32API.StartSTATask(() =>

src/Files.App/Helpers/NativeFileOperationsHelper.cs

@@ -465,13 +465,6 @@ public static bool WriteBufferToFileWithProgress(string filePath, byte[] buffer,
             return null;
         }
 
-        public static SafeFileHandle OpenProtectedFileForRead(string filePath, bool readWrite = false)
-        {
-            var handle = FileOperationsHelpers.GetFileHandle(filePath, readWrite, System.Diagnostics.Process.GetCurrentProcess().Id);
-
-            return new SafeFileHandle(new IntPtr(handle ?? -1), true);
-        }
-
         // https://github.com/rad1oactive/BetterExplorer/blob/master/Windows%20API%20Code%20Pack%201.1/source/WindowsAPICodePack/Shell/ReparsePoint.cs
         public static string ParseSymLink(string path)
         {