Fix: Prevent crash on fresh startup #10031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yaira2
changed the title
yaira2
reviewed
Sep 21, 2022
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, we assume that a null return value for
ReadFromFile()is possible. This assumption causes a crash on startup when incorrectly attempting to deserialize the empty string returned on a fresh installation. This PR makes no changes to theReadFromFile()method body, as that is out of scope, but instead adjusts the return type to not statically assert null values are possible. Additionally, we will now test for both null andstring.EmptyinDefaultJsonSettingsDatabaseto fix the issue, while ensuring maximum compatibility with future changes to theReadFromFile()method.Validation
How did you test these changes?