Convert FileOperationsHandler + FileTagsHandler to helpers

[itsWindows11]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Related Feature: Improving Performance, optimizations, reliability and codebase  #4180.
• Related Feature: Remove FullTrust handlers #9858

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

[hez2010]

Did a rough review and left some suggestions.

[itsWindows11]

hmm, I don't think there's another process that's using this file

---> System.IO.IOException: The process cannot access the file 'C:\Users\itswi\AppData\Local\Packages\FilesDev_ykqwq8d6ps0ag\LocalState\filetags.db' because it is being used by another process.

[hez2010]

Can you verify is Files still able to launch? I cannot launch Files on my computer with this PR anymore, it hangs in the background constantly.

[itsWindows11]

Can you verify is Files still able to launch? I cannot launch Files on my computer with this PR anymore, it hangs in the background constantly.

Works for me, dunno why it shouldn't work for you

[hez2010]

Works for me, dunno why it shouldn't work for you

Did you try deploying a Release package and running it?

[itsWindows11]

Nope, will try in a few hours

[hez2010]

May related: #10031
Will test again after that PR merged.

[hez2010]

May related: #10031
Will test again after that PR merged.

Can confirm it's #10031.

Other findings:

• Paste: doesn't work
• Delete: doesn't work
• Property-Security: doesn't work
• Create items: doesn't work

[hez2010]

hmm, I don't think there's another process that's using this file

---> System.IO.IOException: The process cannot access the file 'C:\Users\itswi\AppData\Local\Packages\FilesDev_ykqwq8d6ps0ag\LocalState\filetags.db' because it is being used by another process.

This is expected becuase now we are trying to open filetags.db across multiple Files instances, which is not supported by LiteDB. You can leave this problem as is and open a new issue for it. We need to use something like mutex to make sure there's only one connection simultaneously, and synchronize the database operations across multiple instances.

[itsWindows11]

I see, will do

[hez2010]

Properties - Details doesn't work.
When paste or delete multiple files, the "ongoing task" doesn't reflect the process properly.
Paste and Delete still doesn't work if there're multiple Files instances running simultaneously.

[itsWindows11]

Properties - Details doesn't work.

I can reproduce this even when building from the main branch so doesn't seem related to this PR.

When paste or delete multiple files, the "ongoing task" doesn't reflect the process properly.
Paste and Delete still doesn't work if there're multiple Files instances running simultaneously.

Will take a look.
EDIT: Attempting to fix that issue results in a crash with the same filetags.db problem, I don't really know how to fix it.

[itsWindows11]

Any news? cc. @hez2010 @yaichenbaum

[hez2010]

Sorry for the delay. Will take care of this PR in next few days.

[yaira2]

@itsWindows11 almost ready to look at this, can you resolve the merge conflicts?

[itsWindows11]

Sure thing, expect some commits tomorrow.

[yaira2]

LGTM
Just noticed the build error

[itsWindows11]

Doesn't look like a build error I can fix; I can compile the app on my end.

[hez2010]

LGTM and tested ok except when it comes to multiple files instances.
@yaichenbaum I think it's fine to merge it as is.
We will need to change how we use LiteDB to open the connection and close it immediately after finishing db operations, and use a Mutex for inter-process synchronization. I'm currently working on this and will open a follow-up PR.

[yaira2]

@itsWindows11 thank you for all you work and keeping up with this PR!