Skip to content

Fix Migration to System.Text.Json #10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

Comments
Pls leave this open as I'm testing for other bugs/problems related to the migration to System.Text.Json
I apologize for not having tested this deeply before committing

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Sep 17, 2022

I found and fixed 2 problems:

  • 1st was related with TabItemArguments (de)serialization
    Details:
    Types needs to be serialized with their FullName in order to work in Deserialization.
    There was a problem with deserialization of object types that were translated to JsonElement.
  • 2nd was related with file-operation-conflicts
    Details:
    JsonElement isn't properly deserialized so we have to get its content as string

I've looked for other issues but I found nothing.
Please, let me know if you run into any Json-related problem (bug/performance)

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 20, 2022
@yaira2 yaira2 merged commit ed81e38 into files-community:main Sep 20, 2022
@ferrariofilippo ferrariofilippo deleted the Fix_System.Text.Json branch September 21, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants