Skip to content

Fixed problem with migration to System.Text.Json #10000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 15, 2022
@yaira2
Copy link
Member

yaira2 commented Sep 15, 2022

Thank you for the quick fix!

@yaira2 yaira2 merged commit 010a7e7 into files-community:main Sep 15, 2022
@0x5bfa
Copy link
Member

0x5bfa commented Sep 16, 2022

@ferrariofilippo This related the following exception?:

image

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2022

Nope, that happens when the json file is empty

@0x5bfa
Copy link
Member

0x5bfa commented Sep 16, 2022

How can I fix?

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2022

It's expected to happen when debugging the app (the json file is replaced through the build pipeline).

@0x5bfa
Copy link
Member

0x5bfa commented Sep 16, 2022

Yeah, but I cannot open Files by occuring on app launching.

If on earth this is expected to happen when debuging, how can I debug or implement new feature by building the app?

@yaira2
Copy link
Member

yaira2 commented Sep 16, 2022

You should be able to ignore the exception and continue using the app.

@ferrariofilippo ferrariofilippo deleted the Fix_Migrate_STJ branch September 21, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants