Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Report the latest deal check timestamp from Singularity as LastVerified #132

Closed
Tracked by #139
masih opened this issue Sep 21, 2023 · 4 comments · Fixed by #136
Closed
Tracked by #139

Report the latest deal check timestamp from Singularity as LastVerified #132

masih opened this issue Sep 21, 2023 · 4 comments · Fixed by #136
Assignees
Labels
beta Feature for Beta release P1

Comments

@masih
Copy link
Member

masih commented Sep 21, 2023

Singularity periodically scans the deals snapshot data from the S3 endpoint; report the latest timestamp at which the check was performed as LastVerified in Motion.

Eventually, checks in Singularity should become more sophisticated to include latest timestamp of proof of replicaiton on chain. However, from Motion perspective reporting the date remains the same: the check timestamp comes from singularity and what the check means is dictated by Singularity.

Relates to #66

@masih masih added the beta Feature for Beta release label Sep 21, 2023
@masih masih changed the title Report the latest deal check timestam from Singularity as LastVerified Report the latest deal check timestamp from Singularity as LastVerified Sep 21, 2023
@elijaharita elijaharita self-assigned this Sep 21, 2023
@elijaharita
Copy link
Contributor

is this info already exposed by singularity or is it going to take a change there first?

@xinaxu
Copy link
Collaborator

xinaxu commented Sep 21, 2023

Singularity will need to add a column for this timestamp first.
@masih

Eventually, checks in Singularity should become more sophisticated to include latest timestamp of proof of replicaiton on chain.

Are we thinking about including the proof of replication as the response from the same call or as part of a separate diagnose API

@masih
Copy link
Member Author

masih commented Sep 22, 2023

@xinaxu Thank you for folagging.

I think the Deal entity in Singularity already has a UpdatedAt field which is also updated as part of deal tracking. Right?

I understand that the UpdatedAt timestamp does not directly represent verification timestamp, but it is a good first iteration considering we return zero-value time right now.

Once checks in signularity get more sophisticated and that timestamp gets separated then it should be a straightforward change in motion: we would simply return a different field instead of UpdatedAt.

I'll capture separate issues for refining this in Signularity.

In the meantime is there anything else that is blocking this issue @elijaharita @xinaxu ?

@xinaxu
Copy link
Collaborator

xinaxu commented Sep 22, 2023

Makes sense to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Feature for Beta release P1
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants