Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

How do we get "LastVerified" for a Replica #66

Closed
hannahhoward opened this issue Aug 23, 2023 · 4 comments
Closed

How do we get "LastVerified" for a Replica #66

hannahhoward opened this issue Aug 23, 2023 · 4 comments
Labels
requirements Design constraints and system requirements

Comments

@hannahhoward
Copy link
Contributor

Just want to flag that determining the last time a deal was verified from the chain is not super easy. We had probably start thinking about the right Lotus API calls needed to get there.

@hannahhoward hannahhoward added M3.0 Motion Retrievals MVP beta Feature for Beta release and removed M3.0 Motion Retrievals MVP labels Aug 23, 2023
@masih
Copy link
Member

masih commented Aug 24, 2023

A bigger question here is what "verified" means. It can be:

  • Deal is published, not expired, not slashed and active on Lotus API the call for which is StateMarketStorageDeal, and
  • Attempt to retrieve a random range of data from the SP.

I think that's about as best as we can do?

Once that's done, then LastVerified would become an internal timestamp.

Also the FIP below will impact this to some extent and verification should ideally not be strongly tied to "deals":

@celine3650
Copy link
Collaborator

celine3650 commented Sep 20, 2023

I was just catching up notes from the product discussion last week 9/12.

Based on the discussion, SP wants to put a green mark on the data verifiability as it's the core value prop of filecoin. That means to be able to read date / time of most recent successful verified deals for each blob is critical.
1. For each SP and given blob, when was the last time it was verified

And for each blob, what was the last successful time + most recent time is how we define "verified"
@masih @hannahhoward @elijaharita Do you agree if we use this as an acceptance criteria to determine the "Lastverified"?

Given the implementation difficulty, a proposed path is to separate diagnostics API that grants Filecoin information for information purposes. Any thoughts on that?

@masih
Copy link
Member

masih commented Sep 20, 2023

@celine3650

@masih
Copy link
Member

masih commented Sep 21, 2023

For Beta, scope reduced to #132. More sophisticated checking will be performed in Singularity eventually and Motion will remain a client of singularity in terms of reporting the last verified date. Therefore, removing the beta label from this issue.

@masih masih removed the beta Feature for Beta release label Sep 21, 2023
@masih masih removed their assignment Oct 5, 2023
@filecoin-project filecoin-project locked and limited conversation to collaborators Oct 5, 2023
@masih masih converted this issue into discussion #146 Oct 5, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
requirements Design constraints and system requirements
Projects
None yet
Development

No branches or pull requests

3 participants