Skip to content

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Oct 7, 2021

Ref: ipld/go-car#254

Depends on getting null-padding added as an option to go-car master, getting a proper tag for this, and getting filecoin-project/go-fil-markets#639 merged (and tagged I suppose).

This is not critical, it's clean-up because Lotus has been depending on a branch of go-car for a long time.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #7468 (92354de) into master (1993efe) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7468      +/-   ##
==========================================
- Coverage   39.21%   39.14%   -0.08%     
==========================================
  Files         631      631              
  Lines       66787    66787              
==========================================
- Hits        26191    26141      -50     
- Misses      36024    36070      +46     
- Partials     4572     4576       +4     
Impacted Files Coverage Δ
node/impl/client/client.go 45.04% <50.00%> (ø)
itests/kit/files.go 97.18% <100.00%> (ø)
journal/types.go 86.66% <0.00%> (-13.34%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-3.97%) ⬇️
journal/fsjournal/fs.go 66.66% <0.00%> (-2.78%) ⬇️
chain/store/store.go 63.00% <0.00%> (-2.50%) ⬇️
miner/miner.go 55.96% <0.00%> (-1.66%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1993efe...92354de. Read the comment docs.

@rvagg
Copy link
Member Author

rvagg commented Oct 8, 2021

I believe that we don't need the zero=eof for go-car v0 usage here anymore, so we just need an upstream v0.3.2 tag and to get that merged in here along with a matching go-fil-markets and go-commp-utils.

@rvagg
Copy link
Member Author

rvagg commented May 10, 2022

resolved in current master

@rvagg rvagg closed this May 10, 2022
@rvagg rvagg deleted the rvagg/go-car-master branch March 1, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants