chore(deps): use go-car master version

[rvagg]

Ref: ipld/go-car#254

Depends on getting null-padding added as an option to go-car master and getting a proper tag for this.

[codecov-commenter]

Codecov Report

Merging #639 (1bbb6e1) into master (36ed4dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files          62       62           
  Lines        4467     4467           
=======================================
  Hits         2913     2913           
  Misses       1273     1273           
  Partials      281      281           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ed4dd...1bbb6e1. Read the comment docs.

[rvagg]

I believe that we don't need the zero=eof for go-car v0 usage here anymore, so we just need an upstream v0.3.2 tag and to get that merged in here (along with a tagged go-commp-utils).

[rvagg]

Now using the tagged, mainline v0.3.2 go-car, working just fine.
This is just blocked by filecoin-project/go-commp-utils#7 being merged and tidied up here.
I'm confident at this stage that the functionality provided by the custom branch of go-car is no longer required because the code paths involved all go through go-car/v2 now which has the functionality available in its mainline releases.

[rvagg]

We have a tagged go-car now and a new go-commp-utils, so this is now just a version bump and clean up of modules, I think this can be merged now (although I had to rerun CI a few times to pass the flakys).

[mvdan]

Depends on getting null-padding added as an option to go-car master and getting a proper tag for this.

Just to clarify, this line from the original post is no longer relevant, right? As you no longer think "zero as EOF" is needed for the uses of the go-car v0 module.

[mvdan]

Assuming we're all in agreement the two unmerged go-car v0 commits aren't actually needed, the changes LGTM!

[rvagg]

Just to clarify, this line from the original post is no longer relevant, right?

Correct, I believe that code paths that need the null=EOF handling (reading from a sector) are now handled by go-car/v2. Same with the Filestore change, or at least roughly similar functionality I think. So the uses of v0 are now very straightforward.

[rvagg]

replaced with #709, this PR was made redundant by #653 anyway