Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nv24 skeleton #12455

Merged
merged 15 commits into from
Sep 13, 2024
Merged

feat: nv24 skeleton #12455

merged 15 commits into from
Sep 13, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 12, 2024

Related Issues

Closes #12351

Pulling in #12419 which @kamuik16 has worked on, and pulling in relevant changes from #12423 which was needed to get some of the tests to pass. Additionally it has been rebased on the latest master.

Proposed Changes

  • Creates the skeleton for NV24

Additional Info

  • This PR should be rebase merged given the large change, and multiple people involved for creating this PR. It has tried to keep each commit to as seperate logical units as possible.

Checklist

Before you mark the PR ready for review, please make sure that:

@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Sep 12, 2024
chore: go mod tidy
@rjan90 rjan90 mentioned this pull request Sep 12, 2024
8 tasks
@rjan90 rjan90 marked this pull request as ready for review September 12, 2024 09:33
@rjan90
Copy link
Contributor Author

rjan90 commented Sep 12, 2024

Sanity test run in devnet:

Network version at the start of the devnet:

lotus state actor-cids
Network Version: 23
Actor Version: 14
Manifest CID: bafy2bzacebwn7ymtozv5yz3x5hnxl4bds2grlgsk5kncyxjak3hqyhslb534m

The pre-migration is happening:

2024-09-12T11:36:20.068+0200	WARN	statemgr	stmgr/forks.go:250	STARTING pre-migration
2024-09-12T11:36:20.069+0200	INFO	bundle	bundle/bundle.go:60	manifest cid: bafy2bzacebwn7ymtozv5yz3x5hnxl4bds2grlgsk5kncyxjak3hqyhslb534m
2024-09-12T11:36:20.070+0200	INFO	fil-consensus	filcns/upgrades.go:2861	Started 5 workers
-------
2024-09-12T11:36:20.072+0200	INFO	fil-consensus	filcns/upgrades.go:2861	All 17 done after 1.685791ms (10084/s)
2024-09-12T11:36:20.072+0200	WARN	statemgr	stmgr/forks.go:263	COMPLETED pre-migration	{"duration": 0.004318125}

The migration at epoch 200:

2024-09-12T11:44:26.468+0200	WARN	statemgr	stmgr/forks.go:202	STARTING migration	{"height": "200", "from": "bafy2bzacedloen32ocgv2rirgubk67jukgwrxzwaioniypn6lwj6ssnswxro6"}
---
2024-09-12T11:44:26.471+0200	WARN	statemgr	stmgr/forks.go:211	COMPLETED migration	{"height": "200", "from": "bafy2bzacedloen32ocgv2rirgubk67jukgwrxzwaioniypn6lwj6ssnswxro6", "to": "bafy2bzacedloen32ocgv2rirgubk67jukgwrxzwaioniypn6lwj6ssnswxro6", "duration": 0.002609167}

We switch actors-bundle version and network version:

lotus state actor-cids
Network Version: 24
Actor Version: 15
Manifest CID: bafy2bzacebwn7ymtozv5yz3x5hnxl4bds2grlgsk5kncyxjak3hqyhslb534m

The network is progressing after the upgrade epoch:

200: (Sep 12 11:44:20) [ bafy2bzaceblxqhgrex47vicokyhq5jcwhmreqjftm3wpj52vor4jet4r2rs34: t01000, ]
201: (Sep 12 11:44:24) [ bafy2bzaceda5jnn7iistoiic2dvc6sex7sndyeuqakmpfozsuit4tuovew3fo: t01000, ]
202: (Sep 12 11:44:28) [ bafy2bzacec6t4ffvhgbpacn3uurrjmkxuizcnml37fwomyd5lpoysd466n2vm: t01000, ]
203: (Sep 12 11:44:32) [ bafy2bzacebs5fxoyhgfjzsd7dll62wjmdp2gwzskeqolt6yk7glmtluor4dtc: t01000, ]
204: (Sep 12 11:44:36) [ bafy2bzaceaydfzlrln53tauqvcqubvfog66vly2pztqf2evlusg4i5sgnlsu6: t01000, ]

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, except that I'd like the actors manifests to be much more obvious that we're not modifying nv23

also strong -1 to "omen"

chore: update network upgrade name
@rjan90
Copy link
Contributor Author

rjan90 commented Sep 12, 2024

also strong -1 to "omen"

I updated the codename now that Tuk Tuk has been settled on as the network upgrade name: filecoin-project/core-devs#150 (reply in thread).

@rjan90 rjan90 self-assigned this Sep 12, 2024
@Stebalien
Copy link
Member

Can we land the bug-fixes into master instead of keeping them in this PR? Unless we're going to land this immediately.

In general, I'm not a huge fan of piling fixes into release PRs. It makes it hard to track/blame them later.

@rjan90 rjan90 merged commit df5cce6 into master Sep 13, 2024
83 checks passed
@rjan90 rjan90 deleted the nv24-skeleton-backup branch September 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

Skeleton for nv24 to support development and testing
5 participants