Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton for nv24 to support development and testing #12351

Closed
rjan90 opened this issue Aug 7, 2024 · 5 comments · Fixed by #12455
Closed

Skeleton for nv24 to support development and testing #12351

rjan90 opened this issue Aug 7, 2024 · 5 comments · Fixed by #12455
Assignees
Labels
good first issue Good for newcomers

Comments

@rjan90
Copy link
Contributor

rjan90 commented Aug 7, 2024

Write the skeleton for nv24, now that the deployment of network version 23 has been completed and landed on Mainnet. This is part of a series of tickets across multiple repos, as building up a network upgrade skeleton requires changes across:

How to create a skeleton in Lotus is documented here: https://github.com/filecoin-project/lotus/blob/master/documentation/misc/Building_a_network_skeleton.md#lotus-checklist

Done Criteria

  • There is a network skeleton in Lotus, which bubbles up all the other dependencies, and allows one to run a 2k-network and see that it switches network version from nv23 --> nv24
@rjan90 rjan90 added the good first issue Good for newcomers label Aug 7, 2024
@kamuik16
Copy link
Contributor

kamuik16 commented Aug 7, 2024

I will take this up in the future once I have completed the rest of the tickets.

@rjan90
Copy link
Contributor Author

rjan90 commented Aug 7, 2024

Amazing! I will assign this ticket to you then @kamuik16

@rjan90
Copy link
Contributor Author

rjan90 commented Aug 21, 2024

I have moved the ticket from Todo to In Progress per communication that work is being started on this week.

@kamuik16 let me know if you have any questions with regards to the steps, either here or on Slack.

@kamuik16
Copy link
Contributor

I have moved the ticket from Todo to In Progress per communication that work is being started on this week.

@kamuik16 let me know if you have any questions with regards to the steps, either here or on Slack.

Do you prefer a different PR for dependency updates (i.e ffi & go-state-types) or all together in a single PR?

@rjan90
Copy link
Contributor Author

rjan90 commented Aug 21, 2024

Do you prefer a different PR for dependency updates (i.e ffi & go-state-types) or all together in a single PR?

All together is fine. That will make it easier to spin up a https://lotus.filecoin.io/lotus/developers/local-network/ from that branch, and confirm that we successfully change network versions

@kamuik16 kamuik16 mentioned this issue Aug 28, 2024
8 tasks
@rjan90 rjan90 mentioned this issue Sep 12, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: ☑️ Done (Archive)
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants