Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(actor events): expanded testing #11673

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Mar 4, 2024

A few things going on here:

  1. Refactored the big DDO verified data test since it's doing so much and getting a bit out of hand; hopefully it's a little cleaner now with some logic extracted to functions
  2. Moved that test to its own file, its size feels like it warrants it, and it's largely events focused rather than being about verified DDO tbqh
  3. Adding additional testing of other FIP0083 events as I can manage it. Some are a bit difficult to trigger so I may not get all the pokemons.

@rvagg rvagg force-pushed the rvagg/moar-actor-events-testing branch 2 times, most recently from 15ff714 to f7701b0 Compare March 5, 2024 00:41
@rvagg
Copy link
Member Author

rvagg commented Mar 5, 2024

Got all of the events I could easily get without adding too much extra workflow. The hard ones are those that involve longer lived sectors/deals and I don't see a good way to override some of the defaults (like min term of a claim, to make a really short one). Will add deal-activated separately when we get that bubbled up through a new actors bundle.

@rvagg rvagg marked this pull request as ready for review March 5, 2024 00:43
@rvagg rvagg requested a review from a team as a code owner March 5, 2024 00:43
@rvagg rvagg force-pushed the rvagg/feat/builtin-actor-events branch from 8151c75 to a7da65d Compare March 5, 2024 01:44
@rvagg rvagg changed the title More builtin actor event testing test(actor events): expanded testing Mar 5, 2024
@rvagg rvagg force-pushed the rvagg/moar-actor-events-testing branch from f7701b0 to 7cc43a2 Compare March 5, 2024 01:48
Base automatically changed from rvagg/feat/builtin-actor-events to release/v1.26.0 March 5, 2024 05:16
@rvagg rvagg force-pushed the rvagg/moar-actor-events-testing branch 2 times, most recently from ae2dc61 to f59b757 Compare March 5, 2024 08:29
@rvagg rvagg force-pushed the rvagg/moar-actor-events-testing branch from f59b757 to 1806135 Compare March 7, 2024 08:38
@rvagg rvagg enabled auto-merge (rebase) March 7, 2024 09:00
@rvagg rvagg disabled auto-merge March 7, 2024 09:10
@rvagg rvagg enabled auto-merge (rebase) March 7, 2024 09:11
@rvagg rvagg merged commit 2bf2706 into release/v1.26.0 Mar 7, 2024
91 checks passed
@rvagg rvagg deleted the rvagg/moar-actor-events-testing branch March 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants