fix(events): deal-activated event on sector_content_changed #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/deal-activated-event
branch
2 times, most recently
from
25ee40d
to
7165293
Compare
rvagg
force-pushed
the
rvagg/deal-activated-event
branch
from
7165293
to
628a29f
Compare
Stebalien
approved these changes
Mar 4, 2024
|
Ah, we need to backport this. |
Stebalien
pushed a commit
that referenced
this pull request
Mar 4, 2024
Stebalien
pushed a commit
that referenced
this pull request
Mar 4, 2024
8 tasks
|
Thanks, 😢 we missed this, and yes we want it in the release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this event is only emitted in
batch_activate_dealsso we never see it otherwise.