feat: multisig: accept arbitrary public messages #1252
Conversation
|
added tests. |
|
Should link to the FIP PR from the description. |
|
added link to fip, tending to clippy. |
vyzo
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
- Coverage 90.70% 90.62% -0.09%
==========================================
Files 133 133
Lines 26964 26969 +5
==========================================
- Hits 24459 24441 -18
- Misses 2505 2528 +23
|
| @@ -569,5 +585,6 @@ impl ActorCode for Actor { | |||
| ChangeNumApprovalsThreshold => change_num_approvals_threshold, | |||
| LockBalance => lock_balance, | |||
| UniversalReceiverHook => universal_receiver_hook, | |||
There was a problem hiding this comment.
We could remove this, since the Universal Receiver Hook's method is in the exported FRC-42 range, so it gets covered by the fallback. But I'd rather keep this explicit branch for clarity. IMO, the account actor should do the same (which it doesn't).
There was a problem hiding this comment.
Suggestion: lets make the change to explicit handling of universal receiver hook to the account actor in this PR
Please don't merge to master until FIP is approved. To reduce WIP, we can run an nv19 integration branch through. This may already be happening: let's discuss in Slack. |
vyzo
changed the title
| // this is arbitrary | ||
| let params = IpldBlock::serialize_cbor(&vec![1u8, 2u8, 3u8]).unwrap(); | ||
|
|
||
| // accept >= 2<<24 |
There was a problem hiding this comment.
Nit: the accept range is >= 2 ^24 (or >= 1 << 24)
| @@ -569,5 +585,6 @@ impl ActorCode for Actor { | |||
| ChangeNumApprovalsThreshold => change_num_approvals_threshold, | |||
| LockBalance => lock_balance, | |||
| UniversalReceiverHook => universal_receiver_hook, | |||
There was a problem hiding this comment.
Suggestion: lets make the change to explicit handling of universal receiver hook to the account actor in this PR
ZenGround0
force-pushed
the
feat/multisig-arb
branch
from
3110627 to
d8023da
Compare
* accept arbitrary messages in multisig * accept arbitrary messages in paych * add tests for fallback method handler in account, multisig, and paych * rustfmt * clippy * moar clippy * leave paych unmolested * names.... * Review Response * Update fallback to mutable runtime * Clippy --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com>
See #1253
FIP: filecoin-project/FIPs#667