Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP-0062: Fallback Method Handler for the Multisig Actor #667

Merged
merged 10 commits into from
Mar 22, 2023

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Mar 20, 2023

FIPS/fip-00XX.md Outdated Show resolved Hide resolved
FIPS/fip-00XX.md Outdated Show resolved Hide resolved
@raulk raulk changed the title Default Method Handlers for multisig and paych actors. Fallback Method Handler for Multisig and Payment Channel Actors Mar 21, 2023
@raulk raulk changed the title Fallback Method Handler for Multisig and Payment Channel Actors FIP-0062: Fallback Method Handler for Multisig and Payment Channel Actors Mar 21, 2023
@raulk raulk force-pushed the fip/multisig-arb branch from 1633c62 to 49f0998 Compare March 21, 2023 15:39
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is our motivation to include payment channel actors too? There aren't a lot of situations today where we send to paychs, and the FIP doesn't really motivate this change.

FIPS/fip-0062.md Outdated Show resolved Hide resolved
FIPS/fip-0062.md Outdated Show resolved Hide resolved
FIPS/fip-0062.md Outdated Show resolved Hide resolved
FIPS/fip-0062.md Outdated Show resolved Hide resolved
@jennijuju
Copy link
Member

approved with nits

Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question for the discussion thread, when it exists:

  • Will this change also remove the implementation of the FRC-0042 universal receiver hook from the multisig? It should note that by touching the payment channel, that actor will also become a valid receiver of such tokens but those tokens will be lost forever because it can't deal with them. Or, maybe don't touch the payment channel.

Editorially approving this draft, but I maintain the questions above wrt whether this is the right change.

FIPS/fip-0062.md Outdated Show resolved Hide resolved
@raulk
Copy link
Member

raulk commented Mar 21, 2023

@anorth

Will this change also remove the implementation of the FRC-0042 universal receiver hook from the multisig?

The blanket acceptance of the exported FRC-42 range makes the code for the universal receiver hook redundant. I will mention that here.

It should note that by touching the payment channel, that actor will also become a valid receiver of such tokens but those tokens will be lost forever because it can't deal with them. Or, maybe don't touch the payment channel.

Alternatively we could deny the universal receiver hook? I don't have a bias and I'm happy descoping the paych from the FIP entirely, if that makes us feel better. Payment channels are hardly used on mainnet, so the lack of support won't be limiting.

EDIT: descoped.

UpdateChannelState activity

image

Settle activity

image

Collect activity

image

@raulk raulk changed the title FIP-0062: Fallback Method Handler for Multisig and Payment Channel Actors FIP-0062: Fallback Method Handler for the Multisig Actor Mar 21, 2023
@anorth anorth merged commit b513427 into master Mar 22, 2023
@anorth anorth deleted the fip/multisig-arb branch March 22, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants