EVM: Refactor FVM precompiles #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need tests & test fixes. |
1. Remove the `length` from `resolve_address` (just take bytes). 2. Fix `call_actor` to follow the solidity conventions with respect to offsets and lengths. 3. Add a new `call_actor_id` that takes an ID instead of an address.
Stebalien
force-pushed
the
refactor/precompile-api
branch
from
6feb4d8
to
f6db5e6
Compare
mriise
reviewed
Jan 13, 2023
|
@Stebalien line 15 |
mriise
suggested changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lengthfromresolve_address(just take bytes).call_actorto follow the solidity conventions with respect to offsets and lengths.call_actor_idthat takes an ID instead of an address.