Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precompiles: call_actor changes #1442

Closed
Stebalien opened this issue Jan 12, 2023 · 2 comments
Closed

Precompiles: call_actor changes #1442

Stebalien opened this issue Jan 12, 2023 · 2 comments
Assignees
@Stebalien
Labels
Kind: Bug Something isn't working
Milestone
M2.1 (rr11) Carbo...

Comments

@Stebalien
Copy link
Member

Necessary:

  1. Fix offsets to match solidity.
  2. Fix overflow when adding sizes.
  3. Write a test that uses abi.encode (in solidity).

Optional:

  1. Split it into call_actor_id and call_actor_address. Most users will want to use call_actor_id.
@Stebalien Stebalien added this to the M2.1 (rr11) Carbonado.2 milestone Jan 12, 2023
@Stebalien Stebalien self-assigned this Jan 12, 2023
@Stebalien Stebalien added the Kind: Bug Something isn't working label Jan 12, 2023
@wadealexc
Copy link

wadealexc commented Jan 12, 2023 •
edited
Loading

Let me know if you want help with 3.

@jennijuju
Copy link
Member

filecoin-project/builtin-actors#1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
Kind: Bug Something isn't working
Projects
None yet
Milestone
M2.1 (rr11) Carbonado.2
Development

No branches or pull requests
3 participants
@Stebalien @wadealexc @jennijuju