Skip to content

chore(internal): update seed test packages #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mallinson/nightly-seed-packaging-testing-branch
Choose a base branch
from
Open

chore(internal): update seed test packages #9695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 155 additions & 0 deletions .github/workflow-resource-files/seed-packages/csharp-model-seed-packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,155 @@
{
"total-test-time": 14420,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whenever providing time as a number, I think always prudent to include the unit. E.g. is this time in ms or s? And typically I just see that appended e.g. total-test-time-ms

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did in parts of the code and didn't pull it up to this output file, will add in the next commit 👍

"split-cutoff-time": 30000,
"split-tests": false,
"packages": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I feel like I don't complete love "package" here since it's so overloaded in build world. Not a strong conviction though.

Maybe cohort or the 5th grade version would be group ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing mentions of packages to groups, I like the 5th grade version 👶

{
"fixtures": [
"auth-environment-variables",
"response-property",
"multiple-request-bodies",
"idempotency-headers",
"unions",
"single-url-environment-default",
"custom-auth",
"single-url-environment-no-default",
"multi-url-environment",
"pagination"
],
"packageTotalTime": 1480
},
{
"fixtures": [
"alias-extends",
"nullable",
"nullable-optional",
"request-parameters",
"license",
"oauth-client-credentials-nested-root",
"objects-with-imports",
"oauth-client-credentials-with-variables",
"circular-references",
"trace"
],
"packageTotalTime": 1482
},
{
"fixtures": [
"api-wide-base-path",
"version-no-default",
"server-sent-event-examples",
"undiscriminated-unions",
"client-side-params",
"error-property",
"streaming-parameter",
"websocket",
"circular-references-advanced"
],
"packageTotalTime": 1415
},
{
"fixtures": [
"bytes-upload",
"csharp-system-collision",
"query-parameters",
"file-download",
"simple-fhir",
"variables",
"oauth-client-credentials-environment-variables",
"websocket-bearer-auth",
"enum:forward-compatible-enums"
],
"packageTotalTime": 1415
},
{
"fixtures": [
"csharp-grpc-proto",
"no-environment",
"public-object",
"literals-unions",
"validation",
"csharp-namespace-collision",
"basic-auth-environment-variables",
"oauth-client-credentials",
"empty-clients",
"audiences"
],
"packageTotalTime": 1486
},
{
"fixtures": [
"query-parameters-openapi",
"object",
"optional",
"file-upload",
"http-head",
"pagination-custom",
"basic-auth",
"inferred-auth-implicit",
"literal",
"exhaustive"
],
"packageTotalTime": 1480
},
{
"fixtures": [
"accept-header",
"version",
"plain-text",
"mixed-case",
"extra-properties",
"inferred-auth-implicit-no-expiry",
"multi-line-docs",
"package-yml",
"examples"
],
"packageTotalTime": 1416
},
{
"fixtures": [
"alias",
"bearer-token-environment-variable",
"simple-api",
"extends",
"csharp-namespace-conflict",
"unknown",
"oauth-client-credentials-custom",
"websocket-inferred-auth",
"folders"
],
"packageTotalTime": 1416
},
{
"fixtures": [
"csharp-grpc-proto-exhaustive",
"bytes-download",
"reserved-keywords",
"server-sent-events",
"oauth-client-credentials-default",
"streaming",
"errors",
"multi-url-environment-no-default",
"enum:plain-enums"
],
"packageTotalTime": 1415
},
{
"fixtures": [
"query-parameters-openapi-as-objects",
"content-type",
"imdb",
"property-access",
"any-auth",
"path-parameters",
"inferred-auth-explicit",
"mixed-file-directory",
"cross-package-type-names"
],
"packageTotalTime": 1415
},
{
"fixtures": ["leftovers"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it this is a reserved fixture name?

A couple of solutions I think are cleaner:

  1. Make fixtures key an undiscriminated union of the literal "leftovers" | String[]. That way we don't have to mess with reserving a magic fixture name, and we get strong validation that "leftovers" is special
  2. Make this implicit (ie remove it) and always allocate it. Would we ever want a case where we don't run the leftovers? I feel like that would result in dropped tests, which we would never want

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from in person conversation, going with option 2, will add the leftovers group in bash. Removing it from here

"packageTotalTime": 0
}
]
}
176 changes: 176 additions & 0 deletions .github/workflow-resource-files/seed-packages/csharp-sdk-seed-packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
{
"total-test-time": 36277,
"split-cutoff-time": 30000,
"split-tests": true,
"packages": [
{
"fixtures": [
"csharp-grpc-proto-exhaustive:package-id",
"multi-url-environment:no-pascal-case-environments",
"path-parameters:no-inline-path-parameters",
"optional:no-custom-config",
"optional:simplify-object-dictionaries",
"http-head",
"unknown",
"empty-clients",
"objects-with-imports",
"request-parameters",
"pagination:no-custom-config",
"circular-references"
],
"packageTotalTime": 3648
},
{
"fixtures": [
"csharp-grpc-proto",
"bytes-upload",
"imdb:no-custom-config",
"errors",
"path-parameters:no-custom-config",
"reserved-keywords",
"license:custom-license",
"response-property",
"custom-auth",
"audiences",
"oauth-client-credentials-with-variables"
],
"packageTotalTime": 3600
},
{
"fixtures": [
"accept-header",
"content-type",
"nullable",
"multi-line-docs",
"license:mit-license",
"single-url-environment-no-default",
"property-access",
"auth-environment-variables",
"simple-api",
"websocket-bearer-auth",
"variables",
"oauth-client-credentials-custom"
],
"packageTotalTime": 3681
},
{
"fixtures": [
"csharp-grpc-proto-exhaustive:read-only-memory",
"imdb:extra-dependencies",
"csharp-system-collision:system-client",
"file-download",
"extends",
"no-environment",
"error-property",
"inferred-auth-implicit",
"inferred-auth-implicit-no-expiry",
"oauth-client-credentials-default",
"trace",
"pagination:custom-pager-with-exception-handler"
],
"packageTotalTime": 3648
},
{
"fixtures": [
"alias",
"csharp-namespace-collision:fully-qualified-namespaces",
"idempotency-headers",
"nullable-optional",
"undiscriminated-unions",
"extra-properties:no-additional-properties",
"server-sent-events",
"basic-auth-environment-variables",
"literals-unions",
"basic-auth",
"imdb:exported-client-class-name",
"circular-references-advanced"
],
"packageTotalTime": 3682
},
{
"fixtures": [
"api-wide-base-path",
"version-no-default",
"multi-url-environment-no-default",
"oauth-client-credentials-nested-root",
"file-upload",
"unions:no-discriminated-unions",
"client-side-params",
"enum:plain-enums",
"streaming",
"folders",
"exhaustive:no-root-namespace-for-core-classes"
],
"packageTotalTime": 3601
},
{
"fixtures": [
"version",
"csharp-grpc-proto-exhaustive:no-custom-config",
"imdb:exception-class-names",
"websocket-inferred-auth",
"csharp-namespace-conflict",
"multiple-request-bodies",
"mixed-case",
"simple-fhir",
"websocket:no-custom-config",
"examples:readme-config",
"enum:forward-compatible-enums"
],
"packageTotalTime": 3604
},
{
"fixtures": [
"alias-extends",
"bearer-token-environment-variable",
"extra-properties:no-custom-config",
"single-url-environment-default",
"websocket:with-websockets",
"multi-url-environment:environment-class-name",
"oauth-client-credentials:include-exception-handler",
"plain-text",
"literal",
"cross-package-type-names",
"exhaustive:include-exception-handler"
],
"packageTotalTime": 3601
},
{
"fixtures": [
"bytes-download",
"query-parameters-openapi",
"unions:no-custom-config",
"public-object",
"query-parameters",
"imdb:include-exception-handler",
"server-sent-event-examples",
"validation",
"any-auth",
"streaming-parameter",
"exhaustive:explicit-namespaces",
"pagination:custom-pager"
],
"packageTotalTime": 3609
},
{
"fixtures": [
"query-parameters-openapi-as-objects",
"csharp-grpc-proto-exhaustive:include-exception-handler",
"pagination-custom",
"package-yml",
"oauth-client-credentials:no-custom-config",
"object",
"inferred-auth-explicit",
"mixed-file-directory",
"oauth-client-credentials-environment-variables",
"examples:no-custom-config",
"exhaustive:no-generate-error-types"
],
"packageTotalTime": 3603
},
{
"fixtures": ["leftovers"],
"packageTotalTime": 0
}
]
}
Loading
Loading