chore(internal): update seed test packages #9695
Conversation
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
force-pushed
the
update-seed-test-packages
branch
from
ddd832f to
53554ef
Compare
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
force-pushed
the
update-seed-test-packages
branch
from
53554ef to
cf8cc83
Compare
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
force-pushed
the
update-seed-test-packages
branch
from
cf8cc83 to
d25b7cc
Compare
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
chrismallinson
force-pushed
the
mallinson/nightly-seed-packaging-testing-branch
branch
from
9204011 to
5fbcc12
Compare
fern-support
force-pushed
the
update-seed-test-packages
branch
from
d25b7cc to
5e1e477
Compare
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
force-pushed
the
update-seed-test-packages
branch
from
5e1e477 to
095d644
Compare
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
force-pushed
the
update-seed-test-packages
branch
from
095d644 to
a7111e7
Compare
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
| @@ -0,0 +1,155 @@ | |||
| { | |||
| "total-test-time": 14420, | |||
There was a problem hiding this comment.
whenever providing time as a number, I think always prudent to include the unit. E.g. is this time in ms or s? And typically I just see that appended e.g. total-test-time-ms
There was a problem hiding this comment.
I did in parts of the code and didn't pull it up to this output file, will add in the next commit 👍
| @@ -0,0 +1,155 @@ | |||
| { | |||
| "total-test-time": 14420, | |||
| "split-cutoff-time": 9600, | |||
There was a problem hiding this comment.
This is my cutoff time for when the file reports back that we should split tests across runners vs running it all in one runner. Per our conversation though, I will move this to the bash side of it, we don't need this answer here.
| "total-test-time": 14420, | ||
| "split-cutoff-time": 9600, | ||
| "split-tests": true, | ||
| "packages": [ |
There was a problem hiding this comment.
nit: I feel like I don't complete love "package" here since it's so overloaded in build world. Not a strong conviction though.
Maybe cohort or the 5th grade version would be group ?
There was a problem hiding this comment.
Changing mentions of packages to groups, I like the 5th grade version 👶
| "packageTotalTime": 1415 | ||
| }, | ||
| { | ||
| "fixtures": ["leftovers"], |
There was a problem hiding this comment.
I take it this is a reserved fixture name?
A couple of solutions I think are cleaner:
- Make
fixtureskey an undiscriminated union of the literal"leftovers" | String[]. That way we don't have to mess with reserving a magic fixture name, and we get strong validation that "leftovers" is special - Make this implicit (ie remove it) and always allocate it. Would we ever want a case where we don't run the leftovers? I feel like that would result in dropped tests, which we would never want
There was a problem hiding this comment.
from in person conversation, going with option 2, will add the leftovers group in bash. Removing it from here
fern-support
force-pushed
the
update-seed-test-packages
branch
from
a7111e7 to
9ad8285
Compare
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
Auto-generated PR, triggered by nightly-seed-packaging workflow with: push from branch: mallinson/nightly-seed-packaging-testing-branch.
GitHub workflow run: https://github.com/fern-api/fern/actions/runs/18141813310