Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request dependency version to 2.87 #12

Merged

Conversation

jonathansamines
Copy link
Contributor

Thanks for this great module. We have been using it for a while now, but the older version of the request module have some know vulnerabilities that we are trying to solve by updating to the latest version available.

  • All tests are passing. Let me know if there is something I need to consider.
  • Latest request version only supports Node > 4. So I updated both the travis and package.engines configuration to reflect the actual support

@Serphentas
Copy link
Collaborator

Serphentas commented Aug 2, 2018

Hey, thanks for the PR.

Looks good to me. Any thoughts @felixge ?

@Serphentas
Copy link
Collaborator

Let's go

@Serphentas Serphentas closed this Oct 26, 2018
@Serphentas Serphentas reopened this Oct 26, 2018
@Serphentas Serphentas merged commit db9b68a into felixge:master Oct 26, 2018
@Serphentas
Copy link
Collaborator

Not actually sure where we use request but I'm doing a new release anyway.

@Serphentas Serphentas mentioned this pull request Oct 29, 2018
@jonathansamines jonathansamines deleted the feature/update-request-version branch November 28, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants