Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 11 compatibility #14

Closed
vincent-ogury opened this issue Oct 29, 2018 · 3 comments
Closed

Node 11 compatibility #14

vincent-ogury opened this issue Oct 29, 2018 · 3 comments

Comments

@vincent-ogury
Copy link

Hi,

I've got this when I use node 11.

error graphite@0.1.3: The engine "node" is incompatible with this module. Expected version ">=4 <10". Got "11.0.0"

Any reason to block node 11?

thanks
@vincent-ogury
Copy link
Author

Same for node 10.

Strange thing is that you add test on node 10, but disable installation for this version ...
I have test against node 11, it works.

@Serphentas
Copy link
Collaborator

Hi,

Actually no specific reason, it's just that in the last PR this changed.

Could you please open a PR for this ?

Thanks.

@jonathansamines jonathansamines mentioned this issue Nov 28, 2018
Merged
@Serphentas
Copy link
Collaborator

See #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Serphentas @vincent-ogury