Skip to content

Wait for in-progress download by other instance with same cache #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alterNERDtive wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Wait for in-progress download by other instance with same cache #1411

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cf00c6
fix: do not fetch release url if file is cached
alterNERDtive Apr 25, 2026
9acb120
fix: use version-unique filename for downloads
alterNERDtive Apr 25, 2026
b87e911
fix: await in-progress download by other instance
alterNERDtive Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 39 additions & 32 deletions src/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,37 +182,6 @@ fi

# Install FoundryVTT if needed
if [ $install_required = true ]; then
# Determine how we are going to get the release URL
if [ "${FOUNDRY_RELEASE_URL:-}" ]; then
log "Using FOUNDRY_RELEASE_URL to download release."
presigned_url="${FOUNDRY_RELEASE_URL}"
fi
if [[ "${FOUNDRY_USERNAME:-}" && "${FOUNDRY_PASSWORD:-}" ]]; then
log "Using FOUNDRY_USERNAME and FOUNDRY_PASSWORD to authenticate."
# If credentials are provided attempt authentication.
# The resulting cookiejar is used to get a release URL or license.

# Temporarily disable errexit to capture failure from authenticate.js
set +e
./authenticate.js ${CONTAINER_VERBOSE+--log-level=debug} \
--user-agent="${node_user_agent}" \
"${FOUNDRY_USERNAME}" "${FOUNDRY_PASSWORD}" "${cookiejar_file}"
auth_exit_code=$?
set -e

if [ ${auth_exit_code} -ne 0 ]; then
log_warn "Authentication failed with exit code ${auth_exit_code}."
rm -f "${cookiejar_file}"
elif [[ ! "${presigned_url:-}" ]]; then
# If the presigned_url wasn't set by FOUNDRY_RELEASE_URL generate one now.
log "Using authenticated credentials to fetch release URL."
presigned_url=$(./get_release_url.js ${CONTAINER_VERBOSE+--log-level=debug} \
${CONTAINER_URL_FETCH_RETRY+--retry=${CONTAINER_URL_FETCH_RETRY}} \
--user-agent="${node_user_agent}" \
"${cookiejar_file}" "${FOUNDRY_VERSION}")
fi
fi

# If CONTAINER_CACHE is null, set it to a default.
# If it is set to an empty string, disable the caching.
CONTAINER_CACHE="${CONTAINER_CACHE-${DATA_DIR}/container_cache}"
Expand All @@ -232,10 +201,48 @@ END_OF_LINE
fi

set +o nounset
downloading_filename="${CONTAINER_CACHE%%+(/)}${CONTAINER_CACHE:+/}downloading.zip"
release_filename="${CONTAINER_CACHE%%+(/)}${CONTAINER_CACHE:+/}foundryvtt-${FOUNDRY_VERSION}.zip"
downloading_filename="${release_filename}.part"
set -o nounset

if [[ ! -f "${release_filename"} ]]; then
# Determine how we are going to get the release URL
if [ "${FOUNDRY_RELEASE_URL:-}" ]; then
log "Using FOUNDRY_RELEASE_URL to download release."
presigned_url="${FOUNDRY_RELEASE_URL}"
fi
if [[ "${FOUNDRY_USERNAME:-}" && "${FOUNDRY_PASSWORD:-}" ]]; then
log "Using FOUNDRY_USERNAME and FOUNDRY_PASSWORD to authenticate."
# If credentials are provided attempt authentication.
# The resulting cookiejar is used to get a release URL or license.

# Temporarily disable errexit to capture failure from authenticate.js
set +e
./authenticate.js ${CONTAINER_VERBOSE+--log-level=debug} \
--user-agent="${node_user_agent}" \
"${FOUNDRY_USERNAME}" "${FOUNDRY_PASSWORD}" "${cookiejar_file}"
auth_exit_code=$?
set -e

if [ ${auth_exit_code} -ne 0 ]; then
log_warn "Authentication failed with exit code ${auth_exit_code}."
rm -f "${cookiejar_file}"
elif [[ ! "${presigned_url:-}" ]]; then
# If the presigned_url wasn't set by FOUNDRY_RELEASE_URL generate one now.
log "Using authenticated credentials to fetch release URL."
presigned_url=$(./get_release_url.js ${CONTAINER_VERBOSE+--log-level=debug} \
${CONTAINER_URL_FETCH_RETRY+--retry=${CONTAINER_URL_FETCH_RETRY}} \
--user-agent="${node_user_agent}" \
"${cookiejar_file}" "${FOUNDRY_VERSION}")
fi
fi
fi

# If another instance is already downloading the requested version, wait
while [[ -f "${downloading_filename}" ]]; do
sleep 1
done

if [[ "${presigned_url:-}" ]]; then
log "Downloading Foundry Virtual Tabletop release."
# Temporarily disable errexit for the curl command to capture its exit status
Expand Down