Wait for in-progress download by other instance with same cache#1411
Draft
alterNERDtive wants to merge 3 commits into
Draft
Wait for in-progress download by other instance with same cache#1411alterNERDtive wants to merge 3 commits into
alterNERDtive wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
If another instance is already downloading our file, we should wait for that download to complete instead of trying to download the same file at the same time (see #1399).
Depends on #1409 and #1410, but apparently stacked PRs are not supported across repositories yet?
Todo: This definitely needs some kind of timeout or other override condition in case a container gets stuck and the download never completes.
💭 Motivation and context
The most glaring problem should already be fixed by #1410, but it’s probably a good idea not to write to the same file multiple times anyway.
🧪 Testing
I haven’t tested this yet, just getting the drafts done before I have to head out.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist