Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove __init__.py for batch materialization engines #3133

Merged
merged 2 commits into from
Aug 24, 2022
Merged

chore: Remove __init__.py for batch materialization engines #3133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440a07a
Remove `__init__.py` for batch materialization engines
felixwang9817 Aug 24, 2022
d10a230
Do not execute `app.py` during doctests
felixwang9817 Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/python/docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,12 @@ Cassandra Online Store
Batch Materialization Engine
============================

.. automodule:: feast.infra.materialization
.. automodule:: feast.infra.materialization.batch_materialization_engine
:members: BatchMaterializationEngine, MaterializationJob, MaterializationTask

Local Engine
------------
.. autoclass:: feast.infra.materialization.LocalMaterializationEngine
.. autoclass:: feast.infra.materialization.local_engine.LocalMaterializationEngine
:members:
:noindex:

Expand Down
20 changes: 0 additions & 20 deletions sdk/python/feast/infra/materialization/__init__.py
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions sdk/python/feast/infra/materialization/aws_lambda/__init__.py
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from feast import FeatureView, RepoConfig
from feast.batch_feature_view import BatchFeatureView
from feast.entity import Entity
from feast.infra.materialization import (
from feast.infra.materialization.batch_materialization_engine import (
BatchMaterializationEngine,
MaterializationJob,
MaterializationTask,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from feast.infra.materialization import MaterializationTask
from feast.infra.materialization.batch_materialization_engine import MaterializationTask


class BytewaxMaterializationTask(MaterializationTask):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/materialization/local_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
from feast.infra.registry.base_registry import BaseRegistry
from feast.repo_config import FeastConfigBaseModel, RepoConfig
from feast.stream_feature_view import StreamFeatureView

from ...utils import (
from feast.utils import (
_convert_arrow_to_proto,
_get_column_names,
_run_pyarrow_field_mapping,
)

from .batch_materialization_engine import (
BatchMaterializationEngine,
MaterializationJob,
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/passthrough_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@
from feast.feature_logging import FeatureServiceLoggingSource
from feast.feature_service import FeatureService
from feast.feature_view import FeatureView
from feast.infra.materialization import BatchMaterializationEngine, MaterializationTask
from feast.infra.materialization.batch_materialization_engine import (
BatchMaterializationEngine,
MaterializationJobStatus,
MaterializationTask,
)
from feast.infra.offline_stores.offline_store import RetrievalJob
from feast.infra.offline_stores.offline_utils import get_offline_store_from_config
Expand Down
Empty file added sdk/python/feast/infra/transformation_servers/__init__.py
View file
Open in desktop
Empty file.
2 changes: 1 addition & 1 deletion sdk/python/feast/repo_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
# - existing values for the online store type in featurestore.yaml files continue to work in a backwards compatible way
# - first party and third party implementations can use the same class loading code path.
BATCH_ENGINE_CLASS_FOR_TYPE = {
"local": "feast.infra.materialization.LocalMaterializationEngine",
"local": "feast.infra.materialization.local_engine.LocalMaterializationEngine",
"snowflake.engine": "feast.infra.materialization.snowflake_engine.SnowflakeMaterializationEngine",
"lambda": "feast.infra.materialization.aws_lambda.lambda_engine.LambdaMaterializationEngine",
"bytewax": "feast.infra.materialization.contrib.bytewax.bytewax_materialization_engine.BytewaxMaterializationEngine",
Expand Down