Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove __init__.py for batch materialization engines #3133

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 24, 2022
Copy link
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #3133 (d10a230) into master (66ee5d8) will increase coverage by 9.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3133      +/-   ##
==========================================
+ Coverage   67.10%   76.12%   +9.01%     
==========================================
  Files         177      211      +34     
  Lines       15893    17836    +1943     
==========================================
+ Hits        10665    13577    +2912     
+ Misses       5228     4259     -969     
Flag Coverage Δ
integrationtests 66.91% <50.00%> (-0.19%) ⬇️
unittests 58.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/passthrough_provider.py 96.29% <ø> (-0.03%) ⬇️
sdk/python/feast/repo_config.py 87.83% <ø> (+5.32%) ⬆️
...python/feast/infra/materialization/local_engine.py 90.47% <100.00%> (ø)
sdk/python/tests/doctest/test_all.py 90.47% <100.00%> (+73.80%) ⬆️
...on/feast/infra/materialization/snowflake_engine.py 92.61% <0.00%> (-0.44%) ⬇️
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
...ib/trino_offline_store/test_config/manual_tests.py 33.33% <0.00%> (ø)
...offline_stores/contrib/trino_repo_configuration.py 20.00% <0.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 50.00% <0.00%> (ø)
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@feast-ci-bot feast-ci-bot merged commit 5da89f5 into feast-dev:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants