Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Write logged features to an offline store (Python API) #2574

Merged
merged 16 commits into from
Apr 26, 2022
Merged

feat: Write logged features to an offline store (Python API) #2574

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2043767
write logs to offline store
pyalex Apr 19, 2022
f3f9998
format
pyalex Apr 19, 2022
af58966
fix after rebase
pyalex Apr 19, 2022
2681b3c
fix tests
pyalex Apr 19, 2022
5637da6
handle table not found in tests
pyalex Apr 19, 2022
43c97c2
some api docs
pyalex Apr 20, 2022
c5c7fbe
fix import
pyalex Apr 21, 2022
eaea5dd
use predefined schema in tests
pyalex Apr 21, 2022
7ac0b83
address pr comments
pyalex Apr 21, 2022
40fe028
more api docs
pyalex Apr 21, 2022
65a1a77
add proto attr to snowflake dest
pyalex Apr 21, 2022
4b983d6
add prefixes to system fields
pyalex Apr 22, 2022
0fc3e5a
add custom destination
pyalex Apr 22, 2022
9d1eb1a
move partition columns to destination config
pyalex Apr 26, 2022
ede26b2
after rebase
pyalex Apr 26, 2022
b2ef41f
allow data source creator implementations w/o logging destination
pyalex Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
after rebase 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
  • Loading branch information
@pyalex
pyalex committed Apr 26, 2022
commit ede26b2ad76a1579df14dde0cf298a13e0c094f0
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/passthrough_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def retrieve_feature_service_logs(
data_source=logging_config.destination.to_data_source(),
join_key_columns=[],
feature_name_columns=columns,
event_timestamp_column=ts_column,
timestamp_field=ts_column,
start_date=start_date,
end_date=end_date,
)