Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Write logged features to an offline store (Python API) #2574

Merged
merged 16 commits into from
Apr 26, 2022
Prev Previous commit
Next Next commit
more api docs
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
  • Loading branch information
pyalex committed Apr 26, 2022
commit 40fe0289c7eae1ba249d5d26bcae285e9ee8a7fe
11 changes: 11 additions & 0 deletions sdk/python/feast/feature_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,14 @@ def __new__(cls, name, bases, dct):


class LoggingDestination:
"""
Logging destination contains details about where exactly logs should be written inside an offline store.
It is implementation specific - each offline store must implement LoggingDestination subclass.

Kind of logging destination will be determined by matching attribute name in LoggingConfig protobuf message
and "_proto_attr_name" property of each subclass.
"""

_proto_attr_name: str

@classmethod
Expand All @@ -131,6 +139,9 @@ def to_proto(self) -> LoggingConfigProto:

@abc.abstractmethod
def to_data_source(self) -> DataSource:
"""
Convert this object into a data source to read logs from an offline store.
"""
raise NotImplementedError


Expand Down