Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the foundation of the universal feature repo and a test that uses it #1734

Merged
merged 20 commits into from
Aug 4, 2021
Merged

Add the foundation of the universal feature repo and a test that uses it #1734

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2c3a7c2
Add the foundation of the universal feature repo and a test that uses it
achals Jul 23, 2021
9f08047
Make tests actually work
achals Jul 27, 2021
a38c7eb
Make format
achals Jul 27, 2021
5d16d32
Make format
achals Jul 27, 2021
e821678
add a redshift data source creator
achals Jul 28, 2021
de49ba8
integration test
achals Jul 28, 2021
57d80ee
file data source creator
achals Jul 29, 2021
f19370b
fix online store ref
achals Jul 29, 2021
eabbcc6
dynamodb region
achals Jul 29, 2021
c49b07c
fix file
achals Jul 29, 2021
73d00ad
remove impor
achals Jul 29, 2021
5879548
close not delete
achals Jul 29, 2021
4b7d4b0
Refactor configs into test_repo_config
achals Aug 2, 2021
63215f3
make forma
achals Aug 2, 2021
1bdd938
Add a sweet decorator per feedback
achals Aug 4, 2021
91bc27a
make format
achals Aug 4, 2021
f44a08f
move stuff into with
achals Aug 4, 2021
66410a4
Specify repo_path for tests to succeed
achals Aug 4, 2021
8f2389c
fix comments
achals Aug 4, 2021
c1cc8ad
fix format
achals Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move stuff into with 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Aug 4, 2021
commit f44a08f69937a9256dc2ceff2cef87bde9c9e7f6
12 changes: 6 additions & 6 deletions sdk/python/tests/integration/feature_repos/test_repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@ def construct_feature_store(test_repo_config: TestRepoConfig) -> FeatureStore:
offline_store=offline_store,
online_store=online_store,
)
fs = FeatureStore(config=config)
fv = correctness_feature_view(ds)
entity = driver
fs.apply([fv, entity])
yield fs
fs = FeatureStore(config=config)
fv = correctness_feature_view(ds)
entity = driver
fs.apply([fv, entity])
yield fs

fs.teardown()
fs.teardown()
offline_creator.teardown(project)


Expand Down