-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the foundation of the universal feature repo and a test that uses it #1734
Add the foundation of the universal feature repo and a test that uses it #1734
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1734 +/- ##
==========================================
+ Coverage 83.85% 84.65% +0.79%
==========================================
Files 73 85 +12
Lines 6009 6268 +259
==========================================
+ Hits 5039 5306 +267
+ Misses 970 962 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sdk/python/tests/integration/feature_repos/universal/data_sources/bigquery.py
Show resolved
Hide resolved
sdk/python/tests/integration/feature_repos/test_repo_configuration.py
Outdated
Show resolved
Hide resolved
sdk/python/tests/integration/feature_repos/universal/entities.py
Outdated
Show resolved
Hide resolved
sdk/python/tests/integration/feature_repos/test_repo_configuration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
ba00666
to
5879548
Compare
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
This PR that implements some of the basis of the universal feature repo as described in the the RFC
It adds a special decorator,
parametrize_e2e_test
, that makes it easy to tag tests to that should be executed against parameterized feature stores that are constructed by the testing framework. This means that users can add e2e tests and have them run against all supported combinations with a single decorator.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: