Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/odin inspector support #33

Closed
wants to merge 13 commits into from
Closed

Feature/odin inspector support #33

wants to merge 13 commits into from

Conversation

Mefodei
Copy link
Contributor

@Mefodei Mefodei commented Jun 4, 2020

  • add optional Odin inspector support
  • move Button Attribute to runtime asm.def

favoyang
favoyang requested changes Jun 7, 2020
View reviewed changes
Copy link
Owner

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing the PR! please see the comments below.

Editor/AddressableImportSettings.cs Outdated Show resolved Hide resolved
CHANGELOG.md.meta Outdated Show resolved Hide resolved
Editor/Helper/AddressablesImporterOdinInspectorDrawer.cs Outdated Show resolved Hide resolved
Editor/Helper/AddressablesImporterOdinInspectorDrawer.cs Outdated Show resolved Hide resolved
Editor/Helper/AddressablesImportsMethodHandler.cs Outdated Show resolved Hide resolved
Runtime/ButtonMethodAttribute.cs Outdated Show resolved Hide resolved
Editor/Helper/ButtonMethodAttribute.cs Show resolved Hide resolved
@favoyang favoyang mentioned this pull request Jun 10, 2020
Closed
@Mefodei Mefodei requested a review from favoyang June 10, 2020 13:17
favoyang
favoyang requested changes Jun 18, 2020
View reviewed changes
Copy link
Owner

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the CR fix.

  • still some unnecessary meta-file changes.
  • a few filename comments.

Editor/Helper.meta Outdated Show resolved Hide resolved
Editor/Unity.AddressableImporter.Editor.asmdef.meta Outdated Show resolved Hide resolved
Editor/Helper/LabelAttribute.cs.meta Outdated Show resolved Hide resolved
Editor/Helper/ConditionalFieldAttribute.cs.meta Outdated Show resolved Hide resolved
Editor/AddressableImportRule.cs.meta Outdated Show resolved Hide resolved
Editor/Helper/AddressablesImporterOdinHandler.cs Outdated Show resolved Hide resolved
Tests/Editor/AddressableImportRuleTests.cs.meta Outdated Show resolved Hide resolved
Tests/Editor/Unity.AddressableImporter.Editor.Tests.asmdef.meta Outdated Show resolved Hide resolved
Editor/Unity.AddressableImporter.Editor.asmdef Outdated Show resolved Hide resolved
Editor/Helper/ButtonMethodScriptableObjectEditor.cs Outdated Show resolved Hide resolved
@Mefodei Mefodei requested a review from favoyang June 26, 2020 12:45
favoyang
favoyang requested changes Jun 26, 2020
View reviewed changes
Copy link
Owner

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the CR fix.

There're minimal reviews left. Please make sure you expand all collapsed files to see all comments.

Editor/AddressableImportSettings.cs.meta Outdated
guid: 4457b6e6d3304bd46a31be63dad3325c
guid: e261d7bf09cd6f143bf70187609b1d80
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fix yet.

Editor/AddressableImporter.cs.meta Outdated
guid: a88f0d7d780c7824daec928bfe13da4f
guid: 83025f04d5722a9419b458539c30cc8b
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fix yet.

Editor/Attributes/ButtonMethodAttribute.cs.meta Outdated
guid: 4c668f9525a32f34aa408a6384243a0a
guid: 5b317eacdc5d30b42a6fcaa311bfa327
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fix yet.

Editor/Helper/AddressablesImporterMethodHandler.cs Outdated
using UnityEditor;
using UnityEngine;

public static class AddressablesImporterMethodHandler
Copy link
Owner

@favoyang favoyang Jun 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed yet, should rename to AddressableImporterMethodHandler.

Editor/Helper/AddressablesImporterOdinHandler.cs Outdated
using Sirenix.OdinInspector.Editor;
using Sirenix.OdinInspector;

public class AddressablesImporterOdinHandler : IDisposable
Copy link
Owner

@favoyang favoyang Jun 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed yet. Should rename to AddressableImporterOdinHandler.

@Mefodei Mefodei requested a review from favoyang June 28, 2020 17:45
favoyang
favoyang approved these changes Jun 29, 2020
View reviewed changes
Copy link
Owner

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Mefodei
Copy link
Contributor Author

Mefodei commented Jul 1, 2020

Nice :)

favoyang pushed a commit that referenced this pull request Jul 6, 2020
@Mefodei @favoyang
feat: ODIN inspector support (close #32, #33)
e7bfcb8
github-actions bot pushed a commit that referenced this pull request Jul 6, 2020
@semantic-release-bot
chore(release): 0.8.0 [skip ci]
13bb7bd 
# [0.8.0](v0.7.3...v0.8.0) (2020-07-06)

### Features

* ODIN inspector support (close [#32](#32), [#33](#33)) ([e7bfcb8](e7bfcb8))
@favoyang
Copy link
Owner

favoyang commented Jul 6, 2020

Closed by e7bfcb8

@favoyang favoyang closed this Jul 6, 2020
favoyang pushed a commit that referenced this pull request Jul 28, 2020
@Mefodei
feat: ODIN inspector search filter (#35)
6d8022c 
* - add optional Odin inspector support
- move Button Attribute to runtime asm.def

* - add optional Odin inspector support
- move Button Attribute to runtime asm.def

* - add FilePath attribue for file usage improvement

* - update odin Addressable Import Rule drawer

* - update odin Addressable Import Rule drawer

* - fix Folder Path attribute

* - fix Force backslashes

* - fix Force backslashes

* #33 fixes

* - add search filter for Odin inspector

* - update addressables import serach filter

* #33
- review fixes

* - fix review comments

* #33

* - fix odin serach filter support

* - fix importer search filter

* - fix ApplyChanges index

* - fix duplicate class def
favoyang pushed a commit that referenced this pull request May 22, 2021
@Mefodei
feat: Odin v3 support (#53)
29dd7bf 
* - add optional Odin inspector support
- move Button Attribute to runtime asm.def

* - add optional Odin inspector support
- move Button Attribute to runtime asm.def

* - add FilePath attribue for file usage improvement

* - update odin Addressable Import Rule drawer

* - update odin Addressable Import Rule drawer

* - fix Folder Path attribute

* - fix Force backslashes

* - fix Force backslashes

* #33 fixes

* - add search filter for Odin inspector

* - update addressables import serach filter

* #33
- review fixes

* - fix review comments

* #33

* - fix odin serach filter support

* - fix importer search filter

* - fix ApplyChanges index

* - fix duplicate class def

* - fix class naming

* update package

* - odin 3 support changes
- remove old odin editor handlers
- add additional filter validators

* - remove namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favoyang favoyang favoyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mefodei @favoyang