-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odin Inspector Support #32
Comments
Hi @Mefodei, Thanks for the idea. Odin looks interesting, but it also needs to clarify what happens if I only reference Odin's namespace with the MIT license. I would be more preferer to depends on an Open Source alternative, but I didn't find a comparable one. |
U can wrap all usage with #IF ODIN_INSPECTOR defines and use all Odin inspector Attributes by Full Namespace. For example: #if ODIN_INSPECTOR
[Sirenix.OdinInspector.Button]
#endif
public void Done()
{
} |
Thanks for the example. I have sent an email to ODIN support to clarify the license issue. I need an official response from them to make sure it's legal to adding ODIN support the way you suggested. I will post the response to this thread when they reply. Overall, I'm not that engaged to add extra support for commercial software, but adding ODIN support can be a workaround to improve UX before the next major release, which requires refactor the current inspector to a window (TBD). #25 (comment). That means the ODIN support maybe reverted later. If I get a positive response from the ODIN team, with all the above considered, would you want to implement the feature as a PR? |
The reply from ODIN is yes, there's no legal issue your way. |
Yes, i can add Odin support PR |
Sounds great! |
Please checkout the code review for #33. |
update review fixes |
BTW, my review was updated. |
🎉 This issue has been resolved in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@all-contributors please add @Mefodei for code |
I've put up a pull request to add @Mefodei! 🎉 |
Hello again.
I'm here to ask you about Odin Inspector support feature
Right now Inspector looks like
https://i.gyazo.com/a8c27e2a952afa27ea9502085b20a70a.png
with Odin it can be more pretty, but you override base imgui drawer. You can use "ODIN INSPECTOR" define for detect Odin features support.
The text was updated successfully, but these errors were encountered: