Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odin Inspector Support #32

Closed
Mefodei opened this issue Jun 1, 2020 · 13 comments
Closed

Odin Inspector Support #32

Mefodei opened this issue Jun 1, 2020 · 13 comments
Labels

Comments

@Mefodei
Copy link
Contributor

Mefodei commented Jun 1, 2020

Hello again.

I'm here to ask you about Odin Inspector support feature
Right now Inspector looks like

https://i.gyazo.com/a8c27e2a952afa27ea9502085b20a70a.png

with Odin it can be more pretty, but you override base imgui drawer. You can use "ODIN INSPECTOR" define for detect Odin features support.

@favoyang
Copy link
Owner

favoyang commented Jun 1, 2020

Hi @Mefodei,

Thanks for the idea. Odin looks interesting, but it also needs to clarify what happens if I only reference Odin's namespace with the MIT license. I would be more preferer to depends on an Open Source alternative, but I didn't find a comparable one.

@Mefodei
Copy link
Contributor Author

Mefodei commented Jun 1, 2020

U can wrap all usage with #IF ODIN_INSPECTOR defines and use all Odin inspector Attributes by Full Namespace. For example:

#if ODIN_INSPECTOR
        [Sirenix.OdinInspector.Button]
#endif
        public void Done()
        {
            
        }

@favoyang
Copy link
Owner

favoyang commented Jun 1, 2020

Thanks for the example.

I have sent an email to ODIN support to clarify the license issue. I need an official response from them to make sure it's legal to adding ODIN support the way you suggested. I will post the response to this thread when they reply.

Overall, I'm not that engaged to add extra support for commercial software, but adding ODIN support can be a workaround to improve UX before the next major release, which requires refactor the current inspector to a window (TBD). #25 (comment). That means the ODIN support maybe reverted later.

If I get a positive response from the ODIN team, with all the above considered, would you want to implement the feature as a PR?

@favoyang
Copy link
Owner

favoyang commented Jun 1, 2020

The reply from ODIN is yes, there's no legal issue your way.

@Mefodei
Copy link
Contributor Author

Mefodei commented Jun 3, 2020

Yes, i can add Odin support PR

@favoyang
Copy link
Owner

favoyang commented Jun 4, 2020

Sounds great!

@Mefodei
Copy link
Contributor Author

Mefodei commented Jun 4, 2020

Push new PR with odin support feature

Importer Inspector

@favoyang
Copy link
Owner

Please checkout the code review for #33.

@Mefodei
Copy link
Contributor Author

Mefodei commented Jun 12, 2020

update review fixes

@favoyang
Copy link
Owner

BTW, my review was updated.

github-actions bot pushed a commit that referenced this issue Jul 6, 2020
# [0.8.0](v0.7.3...v0.8.0) (2020-07-06)

### Features

* ODIN inspector support (close [#32](#32), [#33](#33)) ([e7bfcb8](e7bfcb8))
@github-actions
Copy link

github-actions bot commented Jul 6, 2020

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@favoyang
Copy link
Owner

favoyang commented Jul 6, 2020

@all-contributors please add @Mefodei for code

@allcontributors
Copy link
Contributor

@favoyang

I've put up a pull request to add @Mefodei! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants