Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package bump - allow click < 8.1 #245

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

qbzenker
Copy link
Contributor

@qbzenker qbzenker commented Dec 20, 2021

This PR #231, enabled click version <=8.0. What I really wanted (doh!) was < 8.1 (ie to be able to use the latest version of click, 8.0.3).

Tested locally with various versions of click in the 8.0.* range and all tests passed.

@qbzenker qbzenker changed the title Use click < 8.1 Package bump - allow click < 8.1 Dec 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #245 (1dd92ac) into master (d13a450) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   94.26%   94.26%   -0.01%     
==========================================
  Files         100      100              
  Lines       10814    10813       -1     
  Branches     1477     1472       -5     
==========================================
- Hits        10194    10193       -1     
  Misses        549      549              
  Partials       71       71              
Impacted Files Coverage Δ
faust/livecheck/patches/aiohttp.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13a450...1dd92ac. Read the comment docs.

@patkivikram patkivikram merged commit 9805612 into faust-streaming:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants