Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency - allow click>=6.7,<=8.0 #231

Merged
merged 5 commits into from
Dec 17, 2021
Merged

Bump dependency - allow click>=6.7,<=8.0 #231

merged 5 commits into from
Dec 17, 2021

Conversation

qbzenker
Copy link
Contributor

@qbzenker qbzenker commented Dec 2, 2021

Description

Allows for click version <=8.0.

Tested locally with various versions of click and all tests passed.

See corresponding issue here: #230.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #231 (8a376fc) into master (6f3c783) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files         100      100           
  Lines       10762    10762           
  Branches     1472     1472           
=======================================
  Hits        10151    10151           
  Misses        542      542           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3c783...8a376fc. Read the comment docs.

@qbzenker
Copy link
Contributor Author

qbzenker commented Dec 9, 2021

Hey @patkivikram, could run the workflows and merge this PR when you feel ready? I would, but as a first-time committer to this repo, I don't have too many permissions. Thank you!!

@qbzenker
Copy link
Contributor Author

Any idea as to when this'll go in @patkivikram?

@taybin taybin merged commit 8d8971a into faust-streaming:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants