fixes checkVersion to try all locations#103
Merged
mcollina merged 2 commits intofastify:masterfrom Aug 21, 2020
adrai:master
Merged
fixes checkVersion to try all locations#103mcollina merged 2 commits intofastify:masterfrom adrai:master
mcollina merged 2 commits intofastify:masterfrom
adrai:master
Conversation
4 tasks
mcollina
reviewed
Aug 21, 2020
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
This should work, can you add a unit test?
Member
Author
|
done |
fox1t
approved these changes
Aug 21, 2020
Member
fox1t
left a comment
fox1t
left a comment
There was a problem hiding this comment.
LGTM
The more we fix this the more it shows its limit.
Member
|
@fox1t agreed, it was a bad design decision to start with. See fastify/fastify#2507. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
#102 (comment)