Fixes fastify version check in ESM context

[fox1t]

Fixes: #101

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[fox1t]

Still need proper ESM tests. Going to add them.

[fox1t]

Test added

[mcollina]

a better solution is to move this check from fastify-plugin to fastify itself.

[mcollina]

lgtm

[RafaelGSS]

Good work!

[L2jLiga]

👍

[mcollina]

lgtm

[adrai]

In AWS Lambda this is causing the unwanted log statement "fastify not found, proceeding anyway"
In AWS Lambda the process.argv are: [ '/var/lang/bin/node', '/var/runtime/index.js' ]

@mcollina Do you want me to create a PR to check it like this?

//...
} else if (process.argv[1] && process.argv[1] !== '/var/runtime/index.js' ) {
//...

[mcollina]

I don't think that's a correct fix. What's the require.main and require.name.filename in lambdas?
In other terms, I think your breakage was caused by b3f4aa1#diff-18e559ebd3cc204a52bc1dc3db2adf8b not this PR.

Can you open a new issue?

[adrai]

You're probably right... will create a little console.log example...

[adrai]

require.main.filename = /var/runtime/index.js

require.main = {
  id: '.',
  path: '/var/runtime',
  exports: {},
  parent: null,
  filename: '/var/runtime/index.js',
  loaded: true,
  children: [
    Module {
      id: '/var/runtime/RAPIDClient.js',
      path: '/var/runtime',
      exports: [Function: RAPIDClient],
      parent: [Circular],
      filename: '/var/runtime/RAPIDClient.js',
      loaded: true,
      children: [Array],
      paths: [Array]
    },
    Module {
      id: '/var/runtime/Runtime.js',
      path: '/var/runtime',
      exports: [Function: Runtime],
      parent: [Circular],
      filename: '/var/runtime/Runtime.js',
      loaded: true,
      children: [Array],
      paths: [Array]
    },
    Module {
      id: '/var/runtime/UserFunction.js',
      path: '/var/runtime',
      exports: [Object],
      parent: [Circular],
      filename: '/var/runtime/UserFunction.js',
      loaded: true,
      children: [Array],
      paths: [Array]
    },
    Module {
      id: '/var/runtime/Errors.js',
      path: '/var/runtime',
      exports: [Object],
      parent: [Module],
      filename: '/var/runtime/Errors.js',
      loaded: true,
      children: [],
      paths: [Array]
    },
    Module {
      id: '/var/runtime/BeforeExitListener.js',
      path: '/var/runtime',
      exports: [Object],
      parent: [Module],
      filename: '/var/runtime/BeforeExitListener.js',
      loaded: true,
      children: [],
      paths: [Array]
    },
    Module {
      id: '/var/runtime/LogPatch.js',
      path: '/var/runtime',
      exports: [Object],
      parent: [Module],
      filename: '/var/runtime/LogPatch.js',
      loaded: true,
      children: [],
      paths: [Array]
    }
  ],
  paths: [ '/var/runtime/node_modules', '/var/node_modules', '/node_modules' ]
}

process.argv = [ '/var/lang/bin/node', '/var/runtime/index.js' ]

[mcollina]

So I think this fix was wrong all the way. Instead of using an if, we need to try them all. Can you send a PR?

[adrai]

Can try to do a quick-fix PR for fastify-plugin, but not enough time for fastify/fastify#2507

[mcollina]

yep, go for the fix here. Essentially we need to try all of those locations.

[adrai]

Is something like this ok?

[adrai]

#103