Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update plugin semver to allow for rc versions #80

Merged
merged 1 commit into from
May 24, 2022
Merged

fix: update plugin semver to allow for rc versions #80

merged 1 commit into from
May 24, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented May 24, 2022 •
edited
Loading

Using ^4.0.0 causes the following error:

fastify-plugin: @fastify/elasticsearch - expected '^4.0.0' fastify version, '4.0.0-rc.3' is installed

You can see this occurring in the CI runs in #79

Checklist

@Fdawgs Fdawgs mentioned this pull request May 24, 2022
Merged
1 task
mcollina
mcollina approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 40f4009 into master May 24, 2022
@Fdawgs Fdawgs deleted the fix/semver branch May 24, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @mcollina