Skip to content

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented May 24, 2022

Not able to use the reusable workflow in this repo due to use of a service container that can only be used with Linux containers, and the reusable workflow runs Linux, macOS, and Windows.

So instead this PR brings all the features from the reusable workflow to the repo.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

@Fdawgs
Copy link
Member Author

Fdawgs commented May 24, 2022

Error is: fastify-plugin: @fastify/elasticsearch - expected '^4.0.0' fastify version, '4.0.0-rc.3' is installed.

@mcollina going to change the version to 4.x or else it will continue to struggle with rc versions.

fastify: '^4.0.0',

@Fdawgs
Copy link
Member Author

Fdawgs commented May 24, 2022

Requires #80 to fix the CI.

@Fdawgs Fdawgs merged commit 4f28d71 into master May 24, 2022
@Fdawgs Fdawgs deleted the ci/updates branch May 24, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants