-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): make definitions nodenext
compatible
#224
Conversation
Do we have a typing test for this? |
CI is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a proper fix and it will just break the existing user.
The proper fix should follow fastify/fastify-cookie#184 or fastify/fastify-static#311
And most likely it requires to fix in all modules including core.
nodenext
compatible
I tried fixing the tests but the error messages are really complex for a person that doesn't know much about fastify's internals. Adding |
I fixed the typings. |
Co-authored-by: KaKa <climba03003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@fox1t can you confirm this is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after Lint fix
Fixes #223
Checklist
npm run test
andnpm run benchmark
and the Code of conduct