Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make type definitons "module": "nodenext" compatible #311

Merged
merged 6 commits into from
Jul 23, 2022
Merged

make type definitons "module": "nodenext" compatible #311

merged 6 commits into from
Jul 23, 2022

Conversation

wight554
Copy link
Contributor

Checklist

@Fdawgs Fdawgs requested a review from a team May 25, 2022 18:31
climba03003
climba03003 requested changes May 25, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment on fastify/fastify-cookie#184 (review)

@wight554 wight554 requested a review from climba03003 July 16, 2022 08:59
@wight554
Copy link
Contributor Author

Any progress on this one?

mcollina
mcollina reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@wight554
Copy link
Contributor Author

Thanks for opening a PR! Can you please add a unit test?

added tests from fastify-cookie, should be g2g

@wight554 wight554 requested a review from mcollina July 19, 2022 10:14
@mcollina
Copy link
Member

Could you rebase on top of master?

@wight554
Copy link
Contributor Author

Could you rebase on top of master?

done

mcollina
mcollina approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@climba03003 @RafaelGSS PTAL

climba03003
climba03003 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I do not like to use namespace.
The types here works just fine and support more area.

RafaelGSS
RafaelGSS approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I concur with avoiding namespaces, though.

@wight554
Copy link
Contributor Author

LGTM. I concur with avoiding namespaces, though.

Well Typescript rewrite with esm support might be good point for future, currently idk if there's a better way to pass current test suite

@mcollina mcollina merged commit 99c61f9 into fastify:master Jul 23, 2022
@climba03003 climba03003 mentioned this pull request Sep 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@climba03003 climba03003 climba03003 approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wight554 @mcollina @climba03003 @RafaelGSS