chore: testing new reusable workflow

[Eomm]

Testing the new reusable workflow

[mcollina]

Seem to work great! Just a note!

[Eomm]

There was an error on the coverage step that requires the --cov --coverage-report=html args.

Run coverallsapp/github-action@master
  with:
    github-token: ***
    parallel: true
    flag-name: run-12-ubuntu-latest
    path-to-lcov: ./coverage/lcov.info
    coveralls-endpoint: https://coveralls.io
Using lcov file: ./coverage/lcov.info
Error: Lcov file not found.

Now the error is the following:

Run coverallsapp/github-action@master
Using lcov file: ./coverage/lcov.info
Error: Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

Not sure the config required to get the coverrals working.

[mcollina]

I would just remove coveralls from everywhere.

[Fdawgs]

Now the error is the following:

Run coverallsapp/github-action@master

Using lcov file: ./coverage/lcov.info

Error: Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

Not sure the config required to get the coverrals working.

I think I talked about this with @mcollina early last year when I was trying to standardise the plugin repos. Some of the repos in the Fastify org do not send coverage to Coveralls or fail to do so if they try (like this one). Fastify-cors is an example of one that does manage to send coverage. If the repo is missing a coveralls badge in the readme then it's one that will most likely fail.

[mcollina]

I would just disable it everywhere, it's not worth it (effort vs the information it provides).

[zekth]

+1 on disabling coveralls if it's a blocker for this feature

[Fdawgs]

@Eomm, v2 of workflows has been released, which has removed all coveralls integration.

[Fdawgs]

The CI badge in the readme may need to be updated if changing from lower to uppercase, but i prefer the uppercase to be honest!

[Eomm]

Good spot: for consistency in the action menu, I would keep the old ci name.

I must say that I like the upper case too 😖

[Fdawgs]

LGTM 👍