fix: correct expandEnv bug when passing in a new object in the data option #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
bodinsamuel
referenced
this pull request
in specfy/specfy
Nov 3, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [env-schema](https://togithub.com/fastify/env-schema) | [`5.2.0` -> `5.2.1`](https://renovatebot.com/diffs/npm/env-schema/5.2.0/5.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/env-schema (env-schema)</summary> ### [`v5.2.1`](https://togithub.com/fastify/env-schema/releases/tag/v5.2.1) [Compare Source](https://togithub.com/fastify/env-schema/compare/v5.2.0...v5.2.1) #### What's Changed - chore(deps-dev): bump tsd from 0.24.1 to 0.25.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/140](https://togithub.com/fastify/env-schema/pull/140) - chore(deps): bump dotenv-expand from 9.0.0 to 10.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/141](https://togithub.com/fastify/env-schema/pull/141) - chore(.gitignore): add clinic by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/145](https://togithub.com/fastify/env-schema/pull/145) - chore(.gitignore): add bun lockfile by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/147](https://togithub.com/fastify/env-schema/pull/147) - chore(deps-dev): bump tsd from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/148](https://togithub.com/fastify/env-schema/pull/148) - docs: Resolve the issue [#​146](https://togithub.com/fastify/env-schema/issues/146). by [@​aderchox](https://togithub.com/aderchox) in [https://github.com/fastify/env-schema/pull/149](https://togithub.com/fastify/env-schema/pull/149) - chore(deps-dev): bump tsd from 0.26.1 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/150](https://togithub.com/fastify/env-schema/pull/150) - chore(deps-dev): bump tsd from 0.27.0 to 0.28.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/151](https://togithub.com/fastify/env-schema/pull/151) - chore(deps-dev): bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.25.24 to 0.26.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/152](https://togithub.com/fastify/env-schema/pull/152) - chore(deps-dev): bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.26.8 to 0.27.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/153](https://togithub.com/fastify/env-schema/pull/153) - chore(deps-dev): bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.27.8 to 0.28.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/154](https://togithub.com/fastify/env-schema/pull/154) - ci: only trigger on pushes to main branches by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/155](https://togithub.com/fastify/env-schema/pull/155) - chore(deps-dev): bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.28.20 to 0.29.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/156](https://togithub.com/fastify/env-schema/pull/156) - docs: update README with section about data loading order by [@​lirantal](https://togithub.com/lirantal) in [https://github.com/fastify/env-schema/pull/158](https://togithub.com/fastify/env-schema/pull/158) - docs: adding reference guide by [@​lirantal](https://togithub.com/lirantal) in [https://github.com/fastify/env-schema/pull/144](https://togithub.com/fastify/env-schema/pull/144) - chore(deps-dev): bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.29.6 to 0.30.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/159](https://togithub.com/fastify/env-schema/pull/159) - chore(deps-dev): bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.30.4 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/160](https://togithub.com/fastify/env-schema/pull/160) - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/env-schema/pull/161](https://togithub.com/fastify/env-schema/pull/161) - test: use `node:` prefix to bypass require.cache call for builtins by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/162](https://togithub.com/fastify/env-schema/pull/162) - chore: add `.gitattributes` file by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/164](https://togithub.com/fastify/env-schema/pull/164) - refactor(index): use object destructuring by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/165](https://togithub.com/fastify/env-schema/pull/165) - refactor(index): use `TypeError` over `Error` by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/166](https://togithub.com/fastify/env-schema/pull/166) - test(fluent-schema): optimize split param by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/env-schema/pull/167](https://togithub.com/fastify/env-schema/pull/167) - fix: correct expandEnv bug when passing in a new object in the data option by [@​serdnam](https://togithub.com/serdnam) in [https://github.com/fastify/env-schema/pull/168](https://togithub.com/fastify/env-schema/pull/168) #### New Contributors - [@​aderchox](https://togithub.com/aderchox) made their first contribution in [https://github.com/fastify/env-schema/pull/149](https://togithub.com/fastify/env-schema/pull/149) - [@​lirantal](https://togithub.com/lirantal) made their first contribution in [https://github.com/fastify/env-schema/pull/158](https://togithub.com/fastify/env-schema/pull/158) - [@​serdnam](https://togithub.com/serdnam) made their first contribution in [https://github.com/fastify/env-schema/pull/168](https://togithub.com/fastify/env-schema/pull/168) **Full Changelog**: fastify/env-schema@v5.2.0...v5.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug I encountered while using
env-schema, which is reproduced here: https://github.com/serdnam/env-schema-expand-bugI have added a test that failed prior to making the needed change and passes with said change, all other tests pass.
This is my first time contributing to the Fastify org, let me know if there is anything that I missed!
Checklist
npm run testandnpm run benchmarkand the Code of conduct