fix: correct expandEnv bug when passing in a new object in the data o…

…ption
fastify · Oct 24, 2023 · b355984 · b355984
1 parent 089c90e
commit b355984
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -68,15 +68,16 @@ function envSchema (_opts) {
 
   /* istanbul ignore else */
   if (env) {
-    if (expandEnv) {
-      require('dotenv-expand').expand({ parsed: process.env })
-    }
     data.unshift(process.env)
   }
 
   const merge = {}
   data.forEach(d => Object.assign(merge, d))
 
+  if (expandEnv) {
+    require('dotenv-expand').expand({ ignoreProcessEnv: true, parsed: merge })
+  }
+
   const ajv = chooseAjvInstance(sharedAjvInstance, opts.ajv)
 
   const valid = ajv.validate(schema, merge)

diff --git a/test/expand.test.js b/test/expand.test.js
@@ -46,6 +46,30 @@ const tests = [
     confExpected: {
       EXPANDED_VALUE_FROM_DOTENV: 'the password is password!'
     }
+  },
+  {
+    name: 'simple object - ok - expandEnv works when passed an arbitrary new object based on process.env as data',
+    schema: {
+      type: 'object',
+      properties: {
+        URL: {
+          type: 'string'
+        },
+        K8S_NAMESPACE: {
+          type: 'string'
+        }
+      }
+    },
+    expandEnv: true,
+    isOk: true,
+    data: {
+      ...process.env,
+      K8S_NAMESPACE: 'hello'
+    },
+    confExpected: {
+      URL: 'https://prefix.hello.pluto.my.domain.com',
+      K8S_NAMESPACE: 'hello'
+    }
   }
 ]